Skip to content

BPA Rule Updates #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kerski wants to merge 8 commits into
base: master
Choose a base branch
from
Open

BPA Rule Updates #247

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ff90f82
Update BPARules.json
kerski Feb 2, 2024
8db4001
Update BPARules.json
kerski Feb 2, 2024
f6f5682
Merge branch 'microsoft:master' into master
kerski May 1, 2024
d0e654a
Update FabricPS-PBIP.psm1
kerski May 1, 2024
fed42d4
Update FabricPS-PBIP.psm1
May 1, 2024
c2f6a5e
Merge branch 'master' of https://github.com/kerski/Analysis-Services
May 1, 2024
ee02106
reset FabricPS-PBIP.psm1
May 1, 2024
b1eebd8
Reset FabricPS-PBIP.psm1
May 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions BestPracticeRules/BPARules.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,7 +440,7 @@
"Severity": 3,
"Scope": "DataColumn, CalculatedColumn, CalculatedTableColumn",
"Expression": "IsAvailableInMDX = false\r\n\r\nand\r\n(\r\nUsedInSortBy.Any()\r\nor\r\nUsedInHierarchies.Any()\r\nor\r\nUsedInVariations.Any()\r\nor\r\nSortByColumn != null\r\n)",
"FixExpression": "IsAvailableInMDX = true",
"FixExpression": "IsAvailableInMDX = true",
"CompatibilityLevel": 1200
},
{
Expand Down Expand Up @@ -593,7 +593,7 @@
"ID": "DATECOLUMN_FORMATSTRING",
"Name": "[Formatting] Provide format string for \"Date\" columns",
"Category": "Formatting",
"Description": "Columns of type \"DateTime\" that have \"Month\" in their names should be formatted as \"mm/dd/yyyy\".",
"Description": "Columns of type \"DateTime\" that have \"Date\" in their names should be formatted as \"mm/dd/yyyy\".",
"Severity": 1,
"Scope": "DataColumn, CalculatedColumn, CalculatedTableColumn",
"Expression": "Name.IndexOf(\"Date\", \"OrdinalIgnoreCase\") >= 0 \r\nand \r\nDataType = \"DateTime\" \r\nand \r\nFormatString <> \"mm/dd/yyyy\"",
Expand Down Expand Up @@ -648,7 +648,7 @@
"Category": "Formatting",
"Severity": 2,
"Scope": "Measure",
"Expression": "not FormatString.Contains(\"$\") and not FormatString.Contains(\"%\") and not (FormatString = \"#,0\" or FormatString = \"#,0.0\")",
"Expression": "(DataType = \"Int64\" or DataType = \"Decimal\" or DataType = \"Double\") and not FormatString.Contains(\"$\") and not FormatString.Contains(\"%\") and not (FormatString = \"#,0\" or FormatString = \"#,0.0\")",
"FixExpression": "FormatString = \"#,0\"",
"CompatibilityLevel": 1200
},
Expand Down