Improve citation and reaction logic#452
Merged
siddharthh98 merged 4 commits intomainfrom Feb 20, 2026
Merged
Conversation
Contributor
siddharthh98
commented
Feb 20, 2026
siddharthh98
commented
- Add GenesysHandoff.sln solution file for project structure.
- Refactor GenesysHandoffAgent to delegate Copilot client creation, activity response processing, and conversation state management to new service classes.
- Introduce ActivityResponseProcessor, CitationEntityProcessor, CitationUrlCleaner, ConversationStateManager, and CopilotClientFactory.
- Move citation and entity processing logic out of the agent for better separation of concerns.
- Improve logging, documentation, and dependency injection for maintainability and testability.
- Remove redundant code and clarify XML docs.
- Add GenesysHandoff.sln solution file for project structure. - Refactor GenesysHandoffAgent to delegate Copilot client creation, activity response processing, and conversation state management to new service classes. - Introduce ActivityResponseProcessor, CitationEntityProcessor, CitationUrlCleaner, ConversationStateManager, and CopilotClientFactory. - Move citation and entity processing logic out of the agent for better separation of concerns. - Improve logging, documentation, and dependency injection for maintainability and testability. - Remove redundant code and clarify XML docs.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the GenesysHandoffAgent to improve separation of concerns by extracting citation processing, activity response handling, conversation state management, and Copilot client creation into dedicated service classes. The refactoring aims to improve code maintainability, testability, and documentation.
Changes:
- Extracted Copilot client creation, activity processing, citation handling, and state management into dedicated service classes
- Improved XML documentation and logging throughout the codebase
- Added GenesysHandoff.sln solution file for project structure
- Changed from AskQuestionAsync to SendActivityAsync API for CopilotClient interaction
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 17 comments.
Show a summary per file
| File | Description |
|---|---|
| GenesysHandoffAgent.cs | Refactored to delegate responsibilities to new service classes; broke down HandleAllActivities into smaller methods |
| Services/CopilotClientFactory.cs | New factory class for creating configured CopilotClient instances |
| Services/ConversationStateManager.cs | New class to manage conversation state properties |
| Services/CitationUrlCleaner.cs | New utility class for removing citation URLs from text |
| Services/CitationEntityProcessor.cs | New class to process and fix citation entities for Teams rendering |
| Services/ActivityResponseProcessor.cs | New class to process Copilot Studio activities and prepare responses |
| GenesysHandoff.sln | New Visual Studio solution file |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
samples/dotnet/GenesysHandoff/Services/ConversationStateManager.cs
Outdated
Show resolved
Hide resolved
samples/dotnet/GenesysHandoff/Services/ActivityResponseProcessor.cs
Outdated
Show resolved
Hide resolved
samples/dotnet/GenesysHandoff/Services/ActivityResponseProcessor.cs
Outdated
Show resolved
Hide resolved
- Refactored GenesysHandoffAgent to use constructor injection for CopilotClientFactory, ActivityResponseProcessor, and ConversationStateManager; registered these as singletons in Program.cs. - Enhanced CopilotClientFactory with required ILogger, robust error handling, and improved configuration validation and logging. - Improved ActivityResponseProcessor: clarified which properties are copied, made channel data handling safer, and added better logging. - Strengthened citation entity and URL processing for robustness and type safety. - Updated ConversationStateManager documentation and clarified default behaviors. - Modified message forwarding to Copilot Studio to construct a new Activity with the correct conversation ID and relevant properties. - Improved parameter validation, XML documentation, and removed unused code for better maintainability and clarity.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
samples/dotnet/GenesysHandoff/Services/ConversationStateManager.cs
Outdated
Show resolved
Hide resolved
Refactored ConversationStateManager to validate arguments and throw exceptions for null/empty values. Updated method signatures and XML docs for clarity. Replaced block comments with line comments in GenesysHandoffAgent.cs. Added using System for exception handling.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MattB-msft
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.