Skip to content

Retrieve "additional_properties" from Entity #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JesuTerraz merged 2 commits into from
Nov 13, 2025
Merged

Retrieve "additional_properties" from Entity #48

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2194200
Change model validation to Entity type
Nov 13, 2025
e0e7418
revent to retrieving "additional_properties"
Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...5-notifications/microsoft_agents_a365/notifications/models/agent_notification_activity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
from typing import Any, Optional, Type, TypeVar
Comment thread
JesuTerraz marked this conversation as resolved.
from microsoft_agents.activity.entity import Entity
from microsoft_agents.activity import Activity
from .notification_types import NotificationTypes
from .email_reference import EmailReference
Expand All @@ -21,18 +22,17 @@ def __init__(self, activity: Activity):
entities = self.activity.entities or []
for ent in entities:
etype = ent.type.lower()
payload = getattr(ent, "properties", ent)

if etype == NotificationTypes.EMAIL_NOTIFICATION.lower() and self._email is None:
try:
self._email = EmailReference.model_validate(payload)
self._email = Entity.model_validate(ent)
Comment thread
JesuTerraz marked this conversation as resolved.
Outdated
self._notification_type = NotificationTypes.EMAIL_NOTIFICATION
except Exception:
self._email = None

if etype == NotificationTypes.WPX_COMMENT.lower() and self._wpx_comment is None:
try:
self._wpx_comment = WpxComment.model_validate(payload)
self._wpx_comment = Entity.model_validate(ent)
Comment thread
JesuTerraz marked this conversation as resolved.
Outdated
self._notification_type = NotificationTypes.WPX_COMMENT
except Exception:
self._wpx_comment = None
Expand Down
Loading