Skip to content

Remove unnecessary Agent class patches from googleadk extension tests #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JesuTerraz merged 2 commits into from
Feb 6, 2026
Merged

Remove unnecessary Agent class patches from googleadk extension tests #169

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1cf5abf
Initial plan
Copilot Feb 6, 2026
42b4a58
Remove unnecessary Agent patches from googleadk tests
Copilot Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions tests/tooling/extensions/googleadk/test_mcp_tool_registration_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,9 +116,6 @@ async def test_add_tool_servers_exchanges_token_when_not_provided(
patch(
"microsoft_agents_a365.tooling.extensions.googleadk.services.mcp_tool_registration_service.get_mcp_platform_authentication_scope"
) as mock_get_scope,
patch(
"microsoft_agents_a365.tooling.extensions.googleadk.services.mcp_tool_registration_service.Agent"
) as mock_agent_class,
):
# Setup mocks
mock_get_scope.return_value = ["https://test.scope/.default"]
Expand All @@ -129,8 +126,6 @@ async def test_add_tool_servers_exchanges_token_when_not_provided(
mock_config_service.list_tool_servers = AsyncMock(return_value=[])
mock_config_service_class.return_value = mock_config_service

mock_agent_class.return_value = mock_agent

from microsoft_agents_a365.tooling.extensions.googleadk import (
McpToolRegistrationService,
)
Expand Down Expand Up @@ -161,9 +156,6 @@ async def test_add_tool_servers_uses_provided_token(
patch(
"microsoft_agents_a365.tooling.extensions.googleadk.services.mcp_tool_registration_service.Utility"
) as mock_utility,
patch(
"microsoft_agents_a365.tooling.extensions.googleadk.services.mcp_tool_registration_service.Agent"
) as mock_agent_class,
):
# Setup mocks
mock_utility.resolve_agent_identity.return_value = "agent-123"
Expand All @@ -173,8 +165,6 @@ async def test_add_tool_servers_uses_provided_token(
mock_config_service.list_tool_servers = AsyncMock(return_value=[])
mock_config_service_class.return_value = mock_config_service

mock_agent_class.return_value = mock_agent

from microsoft_agents_a365.tooling.extensions.googleadk import (
McpToolRegistrationService,
)
Expand Down