Skip to content

Default exporter to agent365.svc.cloud.microsoft and remove useCustomDomainForObservability#212

Merged
nikhilNava merged 3 commits intomainfrom
copilot/make-nodejs-sdk-default-to-custom-domain
Feb 27, 2026
Merged

Default exporter to agent365.svc.cloud.microsoft and remove useCustomDomainForObservability#212
nikhilNava merged 3 commits intomainfrom
copilot/make-nodejs-sdk-default-to-custom-domain

Conversation

Copy link
Contributor

Copilot AI commented Feb 27, 2026

Aligns with Agent365-python#184. The exporter now defaults to https://agent365.svc.cloud.microsoft instead of discovering per-tenant IL endpoints via PowerPlatformApiDiscovery. The useCustomDomainForObservability toggle is removed since custom domain is now the only behavior.

Exporter changes (Agent365Exporter.ts)

  • Removed PowerPlatformApiDiscovery — endpoint resolution is now: domain override → resolveAgent365Endpoint(clusterCategory)
  • Updated URL paths to include tenantId: /observability/tenants/{tenantId}/agents/{agentId}/traces (S2S: /observabilityService/...)
  • x-ms-tenant-id header is now always set

Removed useCustomDomainForObservability

  • Removed getter from ObservabilityConfiguration
  • Removed option from ObservabilityConfigurationOptions
  • Removed utility function from exporter utils.ts
  • Removed A365_OBSERVABILITY_USE_CUSTOM_DOMAIN env var references
  • Removed all associated tests across 4 test files

Endpoint resolution (before → after)

# Before (3-way branch)
domainOverride → useCustomDomain? → PowerPlatformApiDiscovery per-tenant

# After
domainOverride → resolveAgent365Endpoint()

Docs

  • Updated design.md, prd-configuration-provider.md, CLAUDE.md

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

…de tenantId

- Remove PowerPlatformApiDiscovery from exporter, always use custom domain
- Endpoint resolution: domain override > resolveAgent365Endpoint()
- Update URL paths: /observability/tenants/{tenantId}/agents/{agentId}/traces
- S2S paths: /observabilityService/tenants/{tenantId}/agents/{agentId}/traces
- Always include x-ms-tenant-id header
- Update tests to reflect new default behavior

Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com>
Copilot AI changed the title [WIP] Make Node.js SDK default to using custom domain Default a365 exporter endpoint to agent365.svc.cloud.microsoft Feb 27, 2026
@nikhilNava nikhilNava marked this pull request as ready for review February 27, 2026 16:49
@nikhilNava nikhilNava requested a review from a team as a code owner February 27, 2026 16:49
Copilot AI review requested due to automatic review settings February 27, 2026 16:49
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Agent365 OpenTelemetry span exporter to default to the Agent365 service endpoint (https://agent365.svc.cloud.microsoft) and removes PPAPI per-tenant discovery from export routing, aligning the Node SDK with the Python SDK behavior.

Changes:

  • Remove PPAPI discovery flow from Agent365Exporter and always resolve via domain override → resolveAgent365Endpoint(clusterCategory).
  • Update exporter URL paths to include tenantId for both non-S2S and S2S endpoints.
  • Always set the x-ms-tenant-id request header and update unit tests accordingly.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
tests/observability/core/agent365-exporter.test.ts Updates test expectations for the new base URL, tenant-in-path routes, and always-present x-ms-tenant-id header.
packages/agents-a365-observability/src/tracing/exporter/Agent365ExporterOptions.ts Updates documentation for the S2S path to reflect the new tenant-in-path route.
packages/agents-a365-observability/src/tracing/exporter/Agent365Exporter.ts Removes PPAPI discovery usage, updates endpoint routing and URL paths, and always sets x-ms-tenant-id.

juliomenendez
juliomenendez previously approved these changes Feb 27, 2026
@nikhilNava nikhilNava enabled auto-merge (squash) February 27, 2026 21:01
@fpfp100
Copy link
Contributor

fpfp100 commented Feb 27, 2026

Need to update the comment. ObservabilityConfigurationOptions.ts:50 still says observabilityDomainOverride is "Only used when useCustomDomainForObservability is true."

…ts, and docs

Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com>
Copilot AI requested a review from a team as a code owner February 27, 2026 21:10
Copilot AI changed the title Default a365 exporter endpoint to agent365.svc.cloud.microsoft Default exporter to agent365.svc.cloud.microsoft and remove useCustomDomainForObservability Feb 27, 2026
@nikhilNava nikhilNava merged commit adecb7f into main Feb 27, 2026
12 checks passed
@nikhilNava nikhilNava deleted the copilot/make-nodejs-sdk-default-to-custom-domain branch February 27, 2026 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants