Default exporter to agent365.svc.cloud.microsoft and remove useCustomDomainForObservability#212
Merged
nikhilNava merged 3 commits intomainfrom Feb 27, 2026
Conversation
…de tenantId
- Remove PowerPlatformApiDiscovery from exporter, always use custom domain
- Endpoint resolution: domain override > resolveAgent365Endpoint()
- Update URL paths: /observability/tenants/{tenantId}/agents/{agentId}/traces
- S2S paths: /observabilityService/tenants/{tenantId}/agents/{agentId}/traces
- Always include x-ms-tenant-id header
- Update tests to reflect new default behavior
Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Make Node.js SDK default to using custom domain
Default a365 exporter endpoint to agent365.svc.cloud.microsoft
Feb 27, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Agent365 OpenTelemetry span exporter to default to the Agent365 service endpoint (https://agent365.svc.cloud.microsoft) and removes PPAPI per-tenant discovery from export routing, aligning the Node SDK with the Python SDK behavior.
Changes:
- Remove PPAPI discovery flow from
Agent365Exporterand always resolve via domain override →resolveAgent365Endpoint(clusterCategory). - Update exporter URL paths to include
tenantIdfor both non-S2S and S2S endpoints. - Always set the
x-ms-tenant-idrequest header and update unit tests accordingly.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/observability/core/agent365-exporter.test.ts | Updates test expectations for the new base URL, tenant-in-path routes, and always-present x-ms-tenant-id header. |
| packages/agents-a365-observability/src/tracing/exporter/Agent365ExporterOptions.ts | Updates documentation for the S2S path to reflect the new tenant-in-path route. |
| packages/agents-a365-observability/src/tracing/exporter/Agent365Exporter.ts | Removes PPAPI discovery usage, updates endpoint routing and URL paths, and always sets x-ms-tenant-id. |
packages/agents-a365-observability/src/tracing/exporter/Agent365Exporter.ts
Show resolved
Hide resolved
packages/agents-a365-observability/src/tracing/exporter/Agent365Exporter.ts
Show resolved
Hide resolved
juliomenendez
previously approved these changes
Feb 27, 2026
fpfp100
reviewed
Feb 27, 2026
packages/agents-a365-observability/src/tracing/exporter/Agent365Exporter.ts
Show resolved
Hide resolved
Contributor
|
Need to update the comment. ObservabilityConfigurationOptions.ts:50 still says observabilityDomainOverride is "Only used when useCustomDomainForObservability is true." |
…ts, and docs Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com>
Copilot
AI
changed the title
Default a365 exporter endpoint to agent365.svc.cloud.microsoft
Default exporter to agent365.svc.cloud.microsoft and remove useCustomDomainForObservability
Feb 27, 2026
fpfp100
approved these changes
Feb 27, 2026
juliomenendez
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns with Agent365-python#184. The exporter now defaults to
https://agent365.svc.cloud.microsoftinstead of discovering per-tenant IL endpoints viaPowerPlatformApiDiscovery. TheuseCustomDomainForObservabilitytoggle is removed since custom domain is now the only behavior.Exporter changes (
Agent365Exporter.ts)PowerPlatformApiDiscovery— endpoint resolution is now: domain override →resolveAgent365Endpoint(clusterCategory)tenantId:/observability/tenants/{tenantId}/agents/{agentId}/traces(S2S:/observabilityService/...)x-ms-tenant-idheader is now always setRemoved
useCustomDomainForObservabilityObservabilityConfigurationObservabilityConfigurationOptionsutils.tsA365_OBSERVABILITY_USE_CUSTOM_DOMAINenv var referencesEndpoint resolution (before → after)
Docs
design.md,prd-configuration-provider.md,CLAUDE.md🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.