Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,10 @@ export class LangChainTracer extends BaseTracer {
spanName = `${operation} ${Utils.getModel(run) || run.name}`.trim();
}

const startTime = Date.now();
const startTime = run.start_time ?? Date.now();
const span = this.tracer.startSpan(spanName, {
kind: SpanKind.INTERNAL,
startTime,
attributes: { [OpenTelemetryConstants.GEN_AI_SYSTEM_KEY]: "langchain" },
}, activeContext);

Expand All @@ -84,8 +85,8 @@ export class LangChainTracer extends BaseTracer {
return;
}

const { span } = entry;
try {
const { span } = entry;
entry.lastAccessTime = Date.now();

if (run.error) {
Expand All @@ -108,8 +109,11 @@ export class LangChainTracer extends BaseTracer {
Utils.setSessionIdAttribute(run, span);
Utils.setTokenAttributes(run, span);

span.end();
} catch (error) {
logger.error(`[LangChainTracer] Error setting span attributes for run ${run.name}: ${error instanceof Error ? error.message : String(error)}`);
span.setStatus({ code: SpanStatusCode.ERROR });
} finally {
span.end(run.end_time ?? undefined);
delete this.runs[run.id];
delete this.parentByRunId[run.id];
await super._endTrace(run);
Expand Down
3 changes: 2 additions & 1 deletion packages/agents-a365-observability-hosting/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,8 @@
"dependencies": {
"@microsoft/agents-a365-observability": "workspace:*",
"@microsoft/agents-a365-runtime": "workspace:*",
"@microsoft/agents-hosting": "catalog:"
"@microsoft/agents-hosting": "catalog:",
"@opentelemetry/api": "catalog:"
},
"devDependencies": {
"@eslint/js": "catalog:",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
// ------------------------------------------------------------------------------

import { TurnContext } from '@microsoft/agents-hosting';
import { TimeInput } from '@opentelemetry/api';
import {
InvokeAgentScope,
InferenceScope,
Expand Down Expand Up @@ -59,6 +60,8 @@ export class ScopeUtils {
agentId: recipient.agenticAppId,
agentName: recipient.name,
agentAUID: recipient.aadObjectId,
agentBlueprintId: recipient.agenticAppBlueprintId,
agentUPN: recipient.agenticUserId,
agentDescription: recipient.role,
tenantId: recipient.tenantId
} as AgentDetails;
Expand All @@ -79,7 +82,8 @@ export class ScopeUtils {
agentAUID: from.aadObjectId,
agentDescription: from.role,
tenantId: from.tenantId,
agentId: from.agenticAppId
agentId: from.agenticAppId,
agentUPN: from.agenticUserId
} as AgentDetails;
}

Expand Down Expand Up @@ -127,11 +131,15 @@ export class ScopeUtils {
* Also records input messages from the context if present.
* @param details The inference call details (model, provider, tokens, etc.).
* @param turnContext The current activity context to derive scope parameters from.
* @param startTime Optional explicit start time (ms epoch, Date, or HrTime).
* @param endTime Optional explicit end time (ms epoch, Date, or HrTime).
* @returns A started `InferenceScope` enriched with context-derived parameters.
*/
static populateInferenceScopeFromTurnContext(
details: InferenceDetails,
turnContext: TurnContext
turnContext: TurnContext,
startTime?: TimeInput,
endTime?: TimeInput
): InferenceScope {
const agent = ScopeUtils.deriveAgentDetails(turnContext);
const tenant = ScopeUtils.deriveTenantDetails(turnContext);
Expand All @@ -145,7 +153,7 @@ export class ScopeUtils {
throw new Error('populateInferenceScopeFromTurnContext: Missing tenant details on TurnContext (recipient)');
}

const scope = InferenceScope.start(details, agent, tenant, conversationId, sourceMetadata);
const scope = InferenceScope.start(details, agent, tenant, conversationId, sourceMetadata, undefined, startTime, endTime);
this.setInputMessageTags(scope, turnContext);
return scope;
}
Expand All @@ -157,11 +165,15 @@ export class ScopeUtils {
* Also sets execution type and input messages from the context if present.
* @param details The invoke-agent call details to be augmented and used for the scope.
* @param turnContext The current activity context to derive scope parameters from.
* @param startTime Optional explicit start time (ms epoch, Date, or HrTime).
* @param endTime Optional explicit end time (ms epoch, Date, or HrTime).
* @returns A started `InvokeAgentScope` enriched with context-derived parameters.
*/
static populateInvokeAgentScopeFromTurnContext(
details: InvokeAgentDetails,
turnContext: TurnContext
turnContext: TurnContext,
startTime?: TimeInput,
endTime?: TimeInput
): InvokeAgentScope {
const tenant = ScopeUtils.deriveTenantDetails(turnContext);
const callerAgent = ScopeUtils.deriveCallerAgent(turnContext);
Expand All @@ -172,7 +184,7 @@ export class ScopeUtils {
throw new Error('populateInvokeAgentScopeFromTurnContext: Missing tenant details on TurnContext (recipient)');
}

const scope = InvokeAgentScope.start(invokeAgentDetails, tenant, callerAgent, caller);
const scope = InvokeAgentScope.start(invokeAgentDetails, tenant, callerAgent, caller, undefined, startTime, endTime);
this.setInputMessageTags(scope, turnContext);
return scope;
}
Expand Down Expand Up @@ -211,11 +223,16 @@ export class ScopeUtils {
* Derives `agentDetails`, `tenantDetails`, `conversationId`, and `sourceMetadata` (channel name/link) from context.
* @param details The tool call details (name, type, args, call id, etc.).
* @param turnContext The current activity context to derive scope parameters from.
* @param startTime Optional explicit start time (ms epoch, Date, or HrTime). Useful when recording a
* tool call after execution has already completed.
* @param endTime Optional explicit end time (ms epoch, Date, or HrTime).
* @returns A started `ExecuteToolScope` enriched with context-derived parameters.
*/
static populateExecuteToolScopeFromTurnContext(
details: ToolCallDetails,
turnContext: TurnContext
turnContext: TurnContext,
startTime?: TimeInput,
endTime?: TimeInput
): ExecuteToolScope {
const agent = ScopeUtils.deriveAgentDetails(turnContext);
const tenant = ScopeUtils.deriveTenantDetails(turnContext);
Expand All @@ -227,7 +244,7 @@ export class ScopeUtils {
if (!tenant) {
throw new Error('populateExecuteToolScopeFromTurnContext: Missing tenant details on TurnContext (recipient)');
}
const scope = ExecuteToolScope.start(details, agent, tenant, conversationId, sourceMetadata);
const scope = ExecuteToolScope.start(details, agent, tenant, conversationId, sourceMetadata, undefined, startTime, endTime);
return scope;
}
}
Loading