Surface query failure explicitly in GetAgentInstancesForBlueprintAsync#305
Merged
gwharris7 merged 2 commits intousers/grantharris/fix-orphaned-instancesfrom Mar 3, 2026
Merged
Conversation
Co-authored-by: gwharris7 <96964444+gwharris7@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update cleanup blueprint to explicitly handle surface query failure
Surface query failure explicitly in GetAgentInstancesForBlueprintAsync
Mar 3, 2026
9a446e4
into
users/grantharris/fix-orphaned-instances
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetAgentInstancesForBlueprintAsyncwas swallowing all Graph/auth exceptions and returning an empty list, making a transient failure indistinguishable from a genuine "0 instances" result — causingcleanup blueprintto silently proceed and potentially recreate orphaned resources.Changes
AgentBlueprintService.cs: Removed thetry/catchinGetAgentInstancesForBlueprintAsync; exceptions now propagate. Updated XML doc to document throwing behavior.AgentBlueprintServiceTests.cs: AddedGetAgentInstancesForBlueprintAsync_Throws_WhenGraphQueryFailsto lock in propagation behavior.CleanupCommandalready had the correct abort-on-failure handler — it just wasn't reachable:🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.