Using EmailResponse when responding to email notifications#145
Merged
Using EmailResponse when responding to email notifications#145
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request implements proper EmailResponse entity wrapping for email notification responses across multiple agent samples in both Python and Node.js implementations. The changes ensure that when agents respond to email notifications, the responses are properly formatted using the EmailResponse entity type as required by the Agent 365 framework.
Key Changes
- Updated email notification handlers to use
createEmailResponseActivity()helper (Node.js) orEmailResponseentity wrapping (Python) for proper response formatting - Replaced placeholder notification handlers with complete email notification processing implementations that retrieve email content and generate appropriate responses
- Fixed spelling errors in notification messages ("Recieved" → "Received")
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| python/claude/sample-agent/host_agent_server.py | Added EmailResponse entity wrapping for email notification responses with conditional check for notification type |
| nodejs/vercel-sdk/sample-agent/src/agent.ts | Implemented full email notification handler using createEmailResponseActivity with error handling |
| nodejs/perplexity/sample-agent/src/notificationService.ts | Replaced stream.sendFinal with createEmailResponseActivity for proper email response formatting |
| nodejs/openai/sample-agent/src/agent.ts | Implemented full email notification handler using createEmailResponseActivity with error handling |
| nodejs/n8n/sample-agent/src/n8nAgent.ts | Wrapped email response in createEmailResponseActivity entity |
| nodejs/langchain/sample-agent/src/agent.ts | Implemented full email notification handler using createEmailResponseActivity with error handling |
| nodejs/devin/sample-agent/src/agent.ts | Added complete agent notification handler with email-specific processing using createEmailResponseActivity |
| nodejs/claude/sample-agent/src/agent.ts | Implemented full email notification handler using createEmailResponseActivity with error handling |
pontemonti
reviewed
Jan 7, 2026
pontemonti
previously approved these changes
Jan 7, 2026
pontemonti
approved these changes
Jan 7, 2026
mengyimicro
approved these changes
Jan 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.