Update EmailResponse object based on documentation#144
Merged
tirthdoshi009 merged 3 commits intomainfrom Jan 6, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the import location of EmailResponse to align with the official documentation. The change moves EmailResponse from microsoft_agents_a365.notifications.agent_notification to microsoft_agents_a365.notifications, reflecting the correct module structure. Additionally, the PR consolidates the ActivityTypes import onto the same line as Activity for improved code organization.
Key Changes:
- Moved
EmailResponseimport to the correct module path (microsoft_agents_a365.notifications) - Consolidated
ActivityTypesimport withActivityimport on a single line
rahuldevikar761
approved these changes
Jan 6, 2026
rahuldevikar761
approved these changes
Jan 6, 2026
Josina20
approved these changes
Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Previous imports pointed to incorrect namespaces, causing ImportError for missing classes. This change aligns with the official SDK structure and ensures compatibility with the latest versions.
Documentation referred
https://learn.microsoft.com/en-us/python/api/microsoft-agents-activity/microsoft_agents.activity?view=agent-sdk-python-latest
https://learn.microsoft.com/en-us/python/api/microsoft-agents-a365-notifications/microsoft_agents_a365.notifications?view=agent365-sdk-python-latest