Fix key concatenation in BuildRulesForFilesInWritableDirectories.ps1 #44
Open
allamiro wants to merge 2 commits intomicrosoft:mainfrom
Open
Fix key concatenation in BuildRulesForFilesInWritableDirectories.ps1 #44allamiro wants to merge 2 commits intomicrosoft:mainfrom
allamiro wants to merge 2 commits intomicrosoft:mainfrom
Conversation
…to correctly append binary name.
- Introduced -VirusTotalLookup switch to query VirusTotal API for SHA256 hashes of unsigned files. - Added -VirusTotalApiKey parameter for API key input, with prompts for user input if not provided. - Implemented functions for hash normalization and API querying, including error handling and rate limiting. - Enhanced output to include VirusTotal threat intelligence data in the "Unsigned file info" worksheet.
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue in BuildRulesForFilesInWritableDirectories.ps1 where publisher rule keys were incorrectly rebuilt when binary name granularity was enabled.
Problem
When PubRuleGranularity is set to
pubProductBinary(default) orpubProdBinVer, the key used for de-duplication is reset instead of appended:This discards the existing publisher and product components, causing different binaries with the same name (in different directories or with different versions/publishers) to collide. As a result, only one DLL is kept. This matches the behavior reported in Issue #43.
Fix
Replace key reassignment with concatenation: and allows multiple binaries with the same name to be processed correctly.
Impact
Fixes #43