Syncing with version 28.0.43307.0

.github/AL-Go-Settings.json

@@ -6,7 +6,7 @@
   "runs-on": "windows-latest",
   "cacheImageName": "",
   "UsePsSession": false,
-  "artifact": "https://bcinsider-fvh2ekdjecfjd6gk.b02.azurefd.net/sandbox/28.0.42149.0/base",
+  "artifact": "https://bcinsider-fvh2ekdjecfjd6gk.b02.azurefd.net/sandbox/28.0.43307.0/base",
   "country": "base",
   "useProjectDependencies": true,
   "repoVersion": "28.0",

Apps/CZ/AdvancePaymentsLocalization/app/Src/Codeunits/AltCustVATRegFacadeCZZ.Codeunit.al

@@ -0,0 +1,40 @@
+// ------------------------------------------------------------------------------------------------
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License. See License.txt in the project root for license information.
+// ------------------------------------------------------------------------------------------------
+namespace Microsoft.Finance.AdvancePayments;
+
+using Microsoft.Sales.Customer;
+
+codeunit 11730 "Alt. Cust. VAT Reg. Facade CZZ"
+{
+    Access = Public;
+
+    var
+        AltCustVATRegOrchCZZ: Codeunit "Alt. Cust. VAT Reg. Orch. CZZ";
+
+    procedure UpdateSetupOnVATCountryChangeInSalesAdvLetterHeader(var SalesAdvLetterHeaderCZZ: Record "Sales Adv. Letter Header CZZ"; xSalesAdvLetterHeaderCZZ: Record "Sales Adv. Letter Header CZZ")
+    begin
+        AltCustVATRegOrchCZZ.GetAltCustVATRegDocImpl().UpdateSetupOnVATCountryChangeInSalesAdvLetterHeader(SalesAdvLetterHeaderCZZ, xSalesAdvLetterHeaderCZZ);
+    end;
+
+    procedure Init(var SalesAdvLetterHeaderCZZ: Record "Sales Adv. Letter Header CZZ"; xSalesAdvLetterHeaderCZZ: Record "Sales Adv. Letter Header CZZ")
+    begin
+        AltCustVATRegOrchCZZ.GetAltCustVATRegDocImpl().Init(SalesAdvLetterHeaderCZZ, xSalesAdvLetterHeaderCZZ);
+    end;
+
+    procedure UpdateVATRegNoInCustFromSalesAdvLetterHeader(SalesAdvLetterHeaderCZZ: Record "Sales Adv. Letter Header CZZ"; Customer: Record Customer) ShouldUpdate: Boolean
+    var
+        IsHandled: Boolean;
+    begin
+        OnBeforeUpdateVATRegNoInCustFromSalesAdvLetterHeader(SalesAdvLetterHeaderCZZ, Customer, ShouldUpdate, IsHandled);
+        if IsHandled then
+            exit(ShouldUpdate);
+        exit((Customer."VAT Registration No." = '') and (not SalesAdvLetterHeaderCZZ."Alt. VAT Registration No."));
+    end;
+
+    [IntegrationEvent(false, false)]
+    local procedure OnBeforeUpdateVATRegNoInCustFromSalesAdvLetterHeader(var SalesAdvLetterHeaderCZZ: Record "Sales Adv. Letter Header CZZ"; Customer: Record Customer; var ShouldUpdate: Boolean; var IsHandled: Boolean)
+    begin
+    end;
+}

Apps/CZ/AdvancePaymentsLocalization/app/Src/Codeunits/AltCustVATRegOrchCZZ.Codeunit.al

@@ -0,0 +1,21 @@
+// ------------------------------------------------------------------------------------------------
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License. See License.txt in the project root for license information.
+// ------------------------------------------------------------------------------------------------
+namespace Microsoft.Finance.AdvancePayments;
+
+using Microsoft.Finance.VAT.Setup;
+
+codeunit 11731 "Alt. Cust. VAT Reg. Orch. CZZ"
+{
+    Access = Internal;
+    InherentEntitlements = X;
+    InherentPermissions = X;
+
+    procedure GetAltCustVATRegDocImpl(): Interface "Alt. Cust. VAT Reg. Adv. CZZ"
+    var
+        VATSetup: Record "VAT Setup";
+    begin
+        exit(VATSetup.Get() ? VATSetup."Alt. Cust. VAT Reg. Adv. CZZ" : "Alt. Cust. VAT Reg. Adv. CZZ"::Default);
+    end;
+}

Apps/CZ/AdvancePaymentsLocalization/app/Src/Codeunits/CrossApplicationHandlerCZZ.Codeunit.al

@@ -1,4 +1,4 @@
-// ------------------------------------------------------------------------------------------------
+// ------------------------------------------------------------------------------------------------
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License. See License.txt in the project root for license information.
 // ------------------------------------------------------------------------------------------------
@@ -11,13 +11,7 @@ using System.Utilities;
 
 codeunit 31418 "Cross Application Handler CZZ"
 {
-#if not CLEAN25
-    ObsoleteState = Pending;
-    ObsoleteReason = 'The Access property will be changed to Internal.';
-    ObsoleteTag = '25.0';
-#else
     Access = Internal;
-#endif
 
     var
         ConfirmManagement: Codeunit "Confirm Management";
@@ -134,4 +128,4 @@ codeunit 31418 "Cross Application Handler CZZ"
                 if not ConfirmManagement.GetResponseOrDefault(StrSubstNo(SuggestedAmountToApplyQst, CashDocumentLineCZP."Advance Letter No. CZZ"), false) then
                     Error('');
     end;
-}
+}

Apps/CZ/AdvancePaymentsLocalization/app/Src/Codeunits/PurchAdvLetterManagementCZZ.Codeunit.al

@@ -299,20 +299,6 @@ codeunit 31019 "PurchAdvLetterManagement CZZ"
         PurchAdvLetterPostCZZ.PostAdvancePayment(
             VendorLedgerEntry, PostedGenJournalLine, GenJnlPostLine, AdvancePostingParametersCZZ);
     end;
-#if not CLEAN25
-    [Obsolete('Replaced by GetAdvanceGLAccountNoCZZ function in GenJournalLine.', '25.0')]
-    procedure GetAdvanceGLAccount(var GenJournalLine: Record "Gen. Journal Line"): Code[20]
-    var
-        PurchAdvLetterHeaderCZZ: Record "Purch. Adv. Letter Header CZZ";
-        AdvanceLetterTemplateCZZ: Record "Advance Letter Template CZZ";
-    begin
-        PurchAdvLetterHeaderCZZ.Get(GenJournalLine."Adv. Letter No. (Entry) CZZ");
-        PurchAdvLetterHeaderCZZ.TestField("Advance Letter Code");
-        AdvanceLetterTemplateCZZ.Get(PurchAdvLetterHeaderCZZ."Advance Letter Code");
-        AdvanceLetterTemplateCZZ.TestField("Advance Letter G/L Account");
-        exit(AdvanceLetterTemplateCZZ."Advance Letter G/L Account");
-    end;
-#endif
 
     procedure PostAdvancePaymentVAT(var PurchAdvLetterEntryCZZ: Record "Purch. Adv. Letter Entry CZZ")
     begin

Apps/CZ/AdvancePaymentsLocalization/app/Src/Codeunits/PurchAdvLetterPostCZZ.Codeunit.al

@@ -2230,11 +2230,6 @@ codeunit 31142 "Purch. Adv. Letter-Post CZZ"
                 GenJournalLine."Source Currency Code" := DetailedVendorLedgEntry1."Currency Code";
                 GenJournalLine."System-Created Entry" := true;
                 OnUnapplyVendLedgEntryOnBeforeUnapplyVendLedgEntry(VendorLedgerEntry, DetailedVendorLedgEntry1, GenJournalLine);
-#if not CLEAN25
-#pragma warning disable AL0432
-                OnUnapplyVendLedgEntryOnBeforePostUnapplyVendLedgEntry(VendorLedgerEntry, DetailedVendorLedgEntry1, GenJournalLine);
-#pragma warning restore AL0432
-#endif
                 GenJnlPostLine.UnapplyVendLedgEntry(GenJournalLine, DetailedVendorLedgEntry1);
             end else
                 Succes := true;
@@ -2857,13 +2852,6 @@ codeunit 31142 "Purch. Adv. Letter-Post CZZ"
     local procedure OnAfterInitGenJournalLineFromVendorLedgerEntry(var VendorLedgerEntry: Record "Vendor Ledger Entry"; var GenJournalLine: Record "Gen. Journal Line")
     begin
     end;
-#if not CLEAN25
-    [Obsolete('Replaced by OnUnapplyVendLedgEntryOnBeforeUnapplyVendLedgEntry event.', '25.0')]
-    [IntegrationEvent(false, false)]
-    local procedure OnUnapplyVendLedgEntryOnBeforePostUnapplyVendLedgEntry(var VendorLedgerEntry: Record "Vendor Ledger Entry"; DetailedVendorLedgEntry1: Record "Detailed Vendor Ledg. Entry"; GenJournalLine: Record "Gen. Journal Line")
-    begin
-    end;
-#endif
 
     [IntegrationEvent(false, false)]
     local procedure OnUnapplyVendLedgEntryOnBeforeUnapplyVendLedgEntry(var VendorLedgerEntry: Record "Vendor Ledger Entry"; var DetailedVendorLedgEntry: Record "Detailed Vendor Ledg. Entry"; var GenJournalLine: Record "Gen. Journal Line")

Apps/CZ/AdvancePaymentsLocalization/app/Src/Codeunits/SalesAdvLetterManagementCZZ.Codeunit.al

@@ -310,20 +310,6 @@ codeunit 31002 "SalesAdvLetterManagement CZZ"
         InsertedEntryNo := SalesAdvLetterPostCZZ.PostAdvancePayment(
             CustLedgerEntry, PostedGenJournalLine, GenJnlPostLine, AdvancePostingParametersCZZ);
     end;
-#if not CLEAN25
-    [Obsolete('Replaced by GetAdvanceGLAccountNoCZZ function in GenJournalLine.', '25.0')]
-    procedure GetAdvanceGLAccount(var GenJournalLine: Record "Gen. Journal Line"): Code[20]
-    var
-        SalesAdvLetterHeaderCZZ: Record "Sales Adv. Letter Header CZZ";
-        AdvanceLetterTemplateCZZ: Record "Advance Letter Template CZZ";
-    begin
-        SalesAdvLetterHeaderCZZ.Get(GenJournalLine."Adv. Letter No. (Entry) CZZ");
-        SalesAdvLetterHeaderCZZ.TestField("Advance Letter Code");
-        AdvanceLetterTemplateCZZ.Get(SalesAdvLetterHeaderCZZ."Advance Letter Code");
-        AdvanceLetterTemplateCZZ.TestField("Advance Letter G/L Account");
-        exit(AdvanceLetterTemplateCZZ."Advance Letter G/L Account");
-    end;
-#endif
 
     procedure PostAdvancePaymentVAT(var SalesAdvLetterEntryCZZ: Record "Sales Adv. Letter Entry CZZ"; PostingDate: Date)
     begin

Apps/W1/OnPrem Permissions/app/Permissions/smtpsetup.permissionset.al → Apps/CZ/AdvancePaymentsLocalization/app/Src/Enums/AltCustVATRegAdvCZZ.Enum.al

@@ -2,14 +2,14 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License. See License.txt in the project root for license information.
 // ------------------------------------------------------------------------------------------------
-#pragma warning disable AA0247
+namespace Microsoft.Finance.AdvancePayments;
 
-permissionset 2271 "SMTP-SETUP"
+enum 11703 "Alt. Cust. VAT Reg. Adv. CZZ" implements "Alt. Cust. VAT Reg. Adv. CZZ"
 {
-    Access = Public;
-    Assignable = true;
-    Caption = 'SMTP Mail Setup';
-    ObsoleteTag = '20.0';
-    ObsoleteState =  Pending;
-    ObsoleteReason = '"SMTP Mail - Admin" has been removed.';
-}
+    Extensible = true;
+    DefaultImplementation = "Alt. Cust. VAT Reg. Adv. CZZ" = "Alt. Cust. VAT Reg. Impl. CZZ";
+
+    value(0; Default)
+    {
+    }
+}

Apps/CZ/AdvancePaymentsLocalization/app/Src/Interfaces/AltCustVATRegAdvCZZ.Interface.al

@@ -0,0 +1,34 @@
+// ------------------------------------------------------------------------------------------------
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License. See License.txt in the project root for license information.
+// ------------------------------------------------------------------------------------------------
+namespace Microsoft.Finance.AdvancePayments;
+
+/// <summary>
+/// The interfaces provides methods to handle the alternative customer VAT registration in the advance letter.
+/// </summary>
+interface "Alt. Cust. VAT Reg. Adv. CZZ"
+{
+    Access = Public;
+
+    /// <summary>
+    /// Initializes the VAT registration data taken from the alternative customer registration in the sales advance letter header.
+    /// </summary>
+    /// <param name="SalesAdvLetterHeaderCZZ">The current sales advance letter header record</param>
+    /// <param name="xSalesAdvLetterHeaderCZZ">The previous version of the record</param>
+    procedure Init(var SalesAdvLetterHeaderCZZ: Record "Sales Adv. Letter Header CZZ"; xSalesAdvLetterHeaderCZZ: Record "Sales Adv. Letter Header CZZ")
+
+    /// <summary>
+    /// Copies the VAT registration data from the customer to the sales advance letter header.
+    /// </summary>
+    /// <param name="SalesAdvLetterHeaderCZZ">The current sales advance letter header record</param>
+    /// <param name="xSalesAdvLetterHeaderCZZ">The previous version of the record</param>
+    procedure CopyFromCustomer(var SalesAdvLetterHeaderCZZ: Record "Sales Adv. Letter Header CZZ"; xSalesAdvLetterHeaderCZZ: Record "Sales Adv. Letter Header CZZ")
+
+    /// <summary>
+    /// Updates the VAT registration data when the VAT Country/Region Code is changed in the sales advance letter header.
+    /// </summary>
+    /// <param name="SalesAdvLetterHeaderCZZ">The current sales advance letter header record</param>
+    /// <param name="xSalesAdvLetterHeaderCZZ">The previous version of the record</param>
+    procedure UpdateSetupOnVATCountryChangeInSalesAdvLetterHeader(var SalesAdvLetterHeaderCZZ: Record "Sales Adv. Letter Header CZZ"; xSalesAdvLetterHeaderCZZ: Record "Sales Adv. Letter Header CZZ")
+}

Apps/CZ/AdvancePaymentsLocalization/app/Src/PageExtensions/PurchaseInvoiceCZZ.PageExt.al

@@ -1,4 +1,4 @@
-// ------------------------------------------------------------------------------------------------
+// ------------------------------------------------------------------------------------------------
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License. See License.txt in the project root for license information.
 // ------------------------------------------------------------------------------------------------
@@ -13,18 +13,6 @@ pageextension 31039 "Purchase Invoice CZZ" extends "Purchase Invoice"
     {
         addlast(factboxes)
         {
-#if not CLEAN25
-            part("Purch. Adv. Usage FactBox CZZ"; "Purch. Adv. Usage FactBox CZZ")
-            {
-                ApplicationArea = Basic, Suite;
-                Provider = PurchLines;
-                SubPageLink = "Document Type" = field("Document Type"), "Document No." = field("Document No."), "Line No." = field("Line No.");
-                Visible = false;
-                ObsoleteState = Pending;
-                ObsoleteReason = 'Replaced by "Advance Usage FactBox CZZ"';
-                ObsoleteTag = '25.0';
-            }
-#endif
             part(AdvanceUsageFactBoxCZZ; "Advance Usage FactBox CZZ")
             {
                 ApplicationArea = Basic, Suite;
@@ -84,4 +72,4 @@ pageextension 31039 "Purchase Invoice CZZ" extends "Purchase Invoice"
         if GuiAllowed() then
             CurrPage.AdvanceUsageFactBoxCZZ.Page.SetDocument(Rec);
     end;
-}
+}

Apps/CZ/AdvancePaymentsLocalization/app/Src/PageExtensions/PurchaseOrderCZZ.PageExt.al

@@ -1,4 +1,4 @@
-// ------------------------------------------------------------------------------------------------
+// ------------------------------------------------------------------------------------------------
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License. See License.txt in the project root for license information.
 // ------------------------------------------------------------------------------------------------
@@ -26,18 +26,6 @@ pageextension 31037 "Purchase Order CZZ" extends "Purchase Order"
         }
         addlast(factboxes)
         {
-#if not CLEAN25
-            part("Purch. Adv. Usage FactBox CZZ"; "Purch. Adv. Usage FactBox CZZ")
-            {
-                ApplicationArea = Basic, Suite;
-                Provider = PurchLines;
-                SubPageLink = "Document Type" = field("Document Type"), "Document No." = field("Document No."), "Line No." = field("Line No.");
-                Visible = false;
-                ObsoleteState = Pending;
-                ObsoleteReason = 'Replaced by "Advance Usage FactBox CZZ"';
-                ObsoleteTag = '25.0';
-            }
-#endif
             part(AdvanceUsageFactBoxCZZ; "Advance Usage FactBox CZZ")
             {
                 ApplicationArea = Basic, Suite;
@@ -126,4 +114,4 @@ pageextension 31037 "Purchase Order CZZ" extends "Purchase Order"
         if GuiAllowed() then
             CurrPage.AdvanceUsageFactBoxCZZ.Page.SetDocument(Rec);
     end;
-}
+}

Apps/CZ/AdvancePaymentsLocalization/app/Src/PageExtensions/SalesInvoiceCZZ.PageExt.al

@@ -1,4 +1,4 @@
-// ------------------------------------------------------------------------------------------------
+// ------------------------------------------------------------------------------------------------
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License. See License.txt in the project root for license information.
 // ------------------------------------------------------------------------------------------------
@@ -13,18 +13,6 @@ pageextension 31027 "Sales Invoice CZZ" extends "Sales Invoice"
     {
         addlast(factboxes)
         {
-#if not CLEAN25
-            part("Sales Adv. Usage FactBox CZZ"; "Sales Adv. Usage FactBox CZZ")
-            {
-                ApplicationArea = Basic, Suite;
-                Provider = SalesLines;
-                SubPageLink = "Document Type" = field("Document Type"), "Document No." = field("Document No."), "Line No." = field("Line No.");
-                Visible = false;
-                ObsoleteState = Pending;
-                ObsoleteReason = 'Replaced by "Advance Usage FactBox CZZ"';
-                ObsoleteTag = '25.0';
-            }
-#endif
             part(AdvanceUsageFactBoxCZZ; "Advance Usage FactBox CZZ")
             {
                 ApplicationArea = Basic, Suite;
@@ -83,4 +71,4 @@ pageextension 31027 "Sales Invoice CZZ" extends "Sales Invoice"
         if GuiAllowed() then
             CurrPage.AdvanceUsageFactBoxCZZ.Page.SetDocument(Rec);
     end;
-}
+}

Apps/CZ/AdvancePaymentsLocalization/app/Src/PageExtensions/SalesOrderCZZ.PageExt.al

@@ -1,4 +1,4 @@
-// ------------------------------------------------------------------------------------------------
+// ------------------------------------------------------------------------------------------------
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License. See License.txt in the project root for license information.
 // ------------------------------------------------------------------------------------------------
@@ -50,18 +50,6 @@ pageextension 31023 "Sales Order CZZ" extends "Sales Order"
         }
         addlast(factboxes)
         {
-#if not CLEAN25
-            part("Sales Adv. Usage FactBox CZZ"; "Sales Adv. Usage FactBox CZZ")
-            {
-                ApplicationArea = Basic, Suite;
-                Provider = SalesLines;
-                SubPageLink = "Document Type" = field("Document Type"), "Document No." = field("Document No."), "Line No." = field("Line No.");
-                Visible = false;
-                ObsoleteState = Pending;
-                ObsoleteReason = 'Replaced by "Advance Usage FactBox CZZ"';
-                ObsoleteTag = '25.0';
-            }
-#endif
             part(AdvanceUsageFactBoxCZZ; "Advance Usage FactBox CZZ")
             {
                 ApplicationArea = Basic, Suite;
@@ -154,4 +142,4 @@ pageextension 31023 "Sales Order CZZ" extends "Sales Order"
         if GuiAllowed() then
             CurrPage.AdvanceUsageFactBoxCZZ.Page.SetDocument(Rec);
     end;
-}
+}