Skip to content

Managing PDF File Extension for ZUGFeRD #29341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
miljance wants to merge 2 commits into from
Closed

Managing PDF File Extension for ZUGFeRD #29341

miljance wants to merge 2 commits into from
+12 −1

Conversation

@miljance
Copy link
Contributor

@miljance miljance commented Oct 27, 2025 •
edited by azure-boards bot
Loading

Summary

Work Item(s)

Fixes microsoft/BCApps#5220 and microsoft/BCApps#5104

Fixes AB#612593

@miljance miljance requested a review from a team as a code owner October 27, 2025 16:27
@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2025

Could not find linked issues in the pull request description. Please make sure the pull request description contains a line that contains 'Fixes #' followed by the issue number being fixed. Use that pattern for every issue you want to link.

@miljance miljance mentioned this pull request Oct 27, 2025
Merged
@JesperSchulz JesperSchulz added the Finance GitHub request for Finance area label Oct 29, 2025
@JesperSchulz JesperSchulz added linked Issue is linked to a Azure Boards work item processing-PR The PR is currently being reviewed labels Nov 10, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 10, 2025

Processing this PR. The branch is now locked 🔒 Please don't push updates unless otherwise agreed.

JesperSchulz added a commit to microsoft/BCApps that referenced this pull request Dec 1, 2025
@miljance @JesperSchulz
Allowing E-Document Attachments to be PDF (#5311)
193320c 
<!-- Thank you for submitting a Pull Request. If you're new to
contributing to BCApps please read our pull request guideline below
* https://github.com/microsoft/BCApps/Contributing.md
-->
#### Summary <!-- Provide a general summary of your changes -->
- Allowing E-Document module to support any extension for an E-document.
Currently *.xml for most of the services except for ZUGFeRD where PDF is
used.
- Each connector that does not use *.xml format should subscribe to
OnAfterGetFileExtension and ship file extension back.
- There is another Pull Request on ALApExtension for ZUGFeRD
- Base for microsoft/ALAppExtensions#29341

#### Work Item(s) <!-- Add the issue number here after the #. The issue
needs to be open and approved. Submitting PRs with no linked issues or
unapproved issues is highly discouraged. -->
Fixes #5220 and #5104





Fixes
[AB#611441](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/611441)

---------

Co-authored-by: Jesper Schulz-Wedde <JesperSchulz@users.noreply.github.com>
@JesperSchulz
Copy link
Contributor

JesperSchulz commented Dec 10, 2025

Re-initiating build.

@JesperSchulz JesperSchulz reopened this Dec 10, 2025
@JesperSchulz
Copy link
Contributor

JesperSchulz commented Dec 10, 2025

Code has been merged internally. Closing this PR. Changes will get pushed out again with next sync.

@JesperSchulz JesperSchulz added the ships-in-future-update Fix ships in a future update label Dec 10, 2025
@JesperSchulz
Copy link
Contributor

JesperSchulz commented Dec 10, 2025

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.

Build ID: 43338.

@djukicmilica djukicmilica mentioned this pull request Dec 22, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JesperSchulz JesperSchulz JesperSchulz approved these changes

@djukicmilica djukicmilica djukicmilica approved these changes

@claudiuciumedean claudiuciumedean Awaiting requested review from claudiuciumedean claudiuciumedean is a code owner automatically assigned from microsoft/dynamics-365-business-central

Assignees

@djukicmilica djukicmilica

Labels

Finance GitHub request for Finance area linked Issue is linked to a Azure Boards work item processing-PR The PR is currently being reviewed ships-in-future-update Fix ships in a future update

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: ZUGFeRD - Sending E-Document in PDF format attached with .xml extension

3 participants

@miljance @JesperSchulz @djukicmilica