ISSUE-174: Annotate topolvm-provisioner sc as default

[kasturinarra]

Summary by CodeRabbit

• Chores
  • Marked the TopoLVM provisioner as the default StorageClass so persistent volumes use it when no class is specified.
  • Build/generation tooling updated to automatically apply that default-setting step during manifest generation.
• Chores (CI)
  • Removed the steps that set and verify the default StorageClass annotation from the CNCF conformance workflow.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

Marked the topolvm-provisioner StorageClass as the cluster default by adding the storageclass.kubernetes.io/is-default-class: "true" annotation and updated the manifest-generation script to apply that annotation during manifest post-processing. The CNCF conformance workflow no longer sets or verifies this default annotation. No control-flow or runtime logic changes.

Changes

Cohort / File(s)	Change Summary
Kubernetes StorageClass Configuration src/topolvm/assets/02-topolvm.yaml	Added metadata.annotations.storageclass.kubernetes.io/is-default-class: "true" to the topolvm-provisioner StorageClass.
Manifest generation script src/topolvm/generate_manifests.sh	Added a yq step to set storageclass.kubernetes.io/is-default-class: "true" on topolvm-provisioner during manifest generation; minor formatting/empty-line adjustment.
CI workflow .github/workflows/cncf-conformance.yaml	Removed steps that annotated and verified the default StorageClass for CNCF conformance tests.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly aligns with the main change: annotating the topolvm-provisioner StorageClass as default across YAML manifest and generation script.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ecda98a and 9946476.

📒 Files selected for processing (3)

• .github/workflows/cncf-conformance.yaml
• src/topolvm/assets/02-topolvm.yaml
• src/topolvm/generate_manifests.sh

💤 Files with no reviewable changes (1)

• .github/workflows/cncf-conformance.yaml

🚧 Files skipped from review as they are similar to previous changes (2)

• src/topolvm/assets/02-topolvm.yaml
• src/topolvm/generate_manifests.sh

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)

• GitHub Check: fedora-bootc (ubuntu-24.04)
• GitHub Check: fedora-bootc (ubuntu-24.04-arm)
• GitHub Check: isolated-network (ovnk, ubuntu-24.04, 1)
• GitHub Check: ubuntu-rpm2deb
• GitHub Check: quick-rpm-and-clean (ubuntu-24.04)
• GitHub Check: centos10-bootc
• GitHub Check: centos9-bootc
• GitHub Check: isolated-network (kindnet, ubuntu-24.04, 0)
• GitHub Check: quick-start-and-clean (ubuntu-24.04-arm)
• GitHub Check: quick-start-and-clean (ubuntu-24.04)
• GitHub Check: quick-rpm-and-clean (ubuntu-24.04-arm)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}