Skip to content

refactor: rename EFAILEDEVAL → EINVALEVAL #706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kikobeats merged 1 commit into from
Mar 6, 2026
Merged

refactor: rename EFAILEDEVAL → EINVALEVAL #706

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/errors/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ The `@browserless/errors` package allows you to:
|---------------|------|-------------|
| `browserTimeout` | `EBRWSRTIMEOUT` | Promise or navigation timed out |
| `protocolError` | `EPROTOCOL` | Chrome DevTools Protocol error |
| `evaluationFailed` | `EFAILEDEVAL` | Page evaluation/script execution failed |
| `evaluationFailed` | `EINVALEVAL` | Page evaluation/script execution failed |
| `contextDisconnected` | `EBRWSRCONTEXTCONNRESET` | Browser context connection was reset |

### Usage
Expand All @@ -56,7 +56,7 @@ const protocolError = errors.protocolError({ message: 'Target closed.' })

// Create an evaluation error
const evalError = errors.evaluationFailed({ message: 'foo is not defined' })
// => BrowserlessError: EFAILEDEVAL, foo is not defined
// => BrowserlessError: EINVALEVAL, foo is not defined

// Normalize a raw error from Puppeteer
const rawError = { message: 'Protocol error (Runtime.callFunctionOn): Target closed.' }
Expand Down
2 changes: 1 addition & 1 deletion packages/errors/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ browserlessError.browserTimeout = createBrowserlessError({
browserlessError.protocolError = createBrowserlessError({ code: 'EPROTOCOL' })

browserlessError.evaluationFailed = createBrowserlessError({
code: 'EFAILEDEVAL',
code: 'EINVALEVAL',
message: 'Evaluation failed'
})

Expand Down
27 changes: 12 additions & 15 deletions packages/errors/test/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,15 +44,15 @@ test('evaluationFailed', t => {

t.true(parsedError instanceof Error)
t.is(parsedError.name, 'BrowserlessError')
t.is(parsedError.code, 'EFAILEDEVAL')
t.is(parsedError.message, "EFAILEDEVAL, Cannot read property 'bar' of undefined")
t.is(parsedError.code, 'EINVALEVAL')
t.is(parsedError.message, "EINVALEVAL, Cannot read property 'bar' of undefined")

const error = errors.evaluationFailed("Cannot read property 'bar' of undefined")

t.true(error instanceof Error)
t.is(error.name, 'BrowserlessError')
t.is(error.code, 'EFAILEDEVAL')
t.is(error.message, "EFAILEDEVAL, Cannot read property 'bar' of undefined")
t.is(error.code, 'EINVALEVAL')
t.is(error.message, "EINVALEVAL, Cannot read property 'bar' of undefined")
}
{
const parsedError = errors.ensureError({
Expand All @@ -61,19 +61,16 @@ test('evaluationFailed', t => {

t.true(parsedError instanceof Error)
t.is(parsedError.name, 'BrowserlessError')
t.is(parsedError.code, 'EFAILEDEVAL')
t.is(parsedError.code, 'EINVALEVAL')

t.is(
parsedError.message,
"EFAILEDEVAL, Cannot read properties of undefined (reading 'versoin')"
)
t.is(parsedError.message, "EINVALEVAL, Cannot read properties of undefined (reading 'versoin')")

const error = errors.evaluationFailed("Cannot read properties of undefined (reading 'versoin')")

t.true(error instanceof Error)
t.is(error.name, 'BrowserlessError')
t.is(error.code, 'EFAILEDEVAL')
t.is(error.message, "EFAILEDEVAL, Cannot read properties of undefined (reading 'versoin')")
t.is(error.code, 'EINVALEVAL')
t.is(error.message, "EINVALEVAL, Cannot read properties of undefined (reading 'versoin')")
}
{
const parsedError = errors.ensureError({
Expand All @@ -82,16 +79,16 @@ test('evaluationFailed', t => {

t.true(parsedError instanceof Error)
t.is(parsedError.name, 'BrowserlessError')
t.is(parsedError.code, 'EFAILEDEVAL')
t.is(parsedError.code, 'EINVALEVAL')

t.is(parsedError.message, 'EFAILEDEVAL, version is not defined')
t.is(parsedError.message, 'EINVALEVAL, version is not defined')

const error = errors.evaluationFailed('version is not defined')

t.true(error instanceof Error)
t.is(error.name, 'BrowserlessError')
t.is(error.code, 'EFAILEDEVAL')
t.is(error.message, 'EFAILEDEVAL, version is not defined')
t.is(error.code, 'EINVALEVAL')
t.is(error.message, 'EINVALEVAL, version is not defined')
}
})

Expand Down
Loading