fix: move acorn and acorn-walk to dependencies#705
Closed
theluckystrike wants to merge 1 commit intomicrolinkhq:masterfrom
Closed
fix: move acorn and acorn-walk to dependencies#705theluckystrike wants to merge 1 commit intomicrolinkhq:masterfrom
theluckystrike wants to merge 1 commit intomicrolinkhq:masterfrom
Conversation
These packages are required at runtime by template.js but were listed as devDependencies, causing crashes in production environments. The issue was masked by transitive dependencies from isolated-function, but this is fragile and should be fixed properly. Fixes issue #694
Contributor
Author
|
Closing — repo is in our already-merged list (PR #702 was merged). Not opening more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These packages are required at runtime by template.js but were listed as devDependencies, causing crashes in production environments.
The issue was masked by transitive dependencies from isolated-function, but this is fragile and should be fixed properly.
Fixes issue #694