Open
Conversation
Member
|
@DaVinci9196 |
mar-v-in
requested changes
Feb 26, 2026
Member
mar-v-in
left a comment
mar-v-in
left a comment
There was a problem hiding this comment.
It seems you are wildly mixing different things here:
- Bluetooth in the transport selection refers to connecting to Bluetooth capable fido tokens. This does not involve qr codes. See https://fidoalliance.org/specs/fido-v2.3-rd-20251023/fido-client-to-authenticator-protocol-v2.3-rd-20251023.html#ble for the protocol specification.
- This seems to implement hybrid authentication in both directions, but weirdly entangles it with unrelated code paths.
play-services-fido/core/src/main/kotlin/org/microg/gms/fido/core/ui/QRBounceActivity.kt
Outdated
Show resolved
Hide resolved
play-services-fido/core/src/main/kotlin/org/microg/gms/fido/core/ui/QRBounceActivity.kt
Outdated
Show resolved
Hide resolved
play-services-core/src/main/kotlin/org/microg/gms/mlkit/BarcodeScanningActivity.kt
Show resolved
Hide resolved
play-services-core/src/main/kotlin/org/microg/gms/ui/AccountsFragment.kt
Outdated
Show resolved
Hide resolved
...ces-fido/core/src/main/kotlin/org/microg/gms/fido/core/protocol/msgs/AuthenticatorGetInfo.kt
Outdated
Show resolved
Hide resolved
mar-v-in
requested changes
Mar 12, 2026
...ces-fido/core/src/main/kotlin/org/microg/gms/fido/core/protocol/msgs/AuthenticatorGetInfo.kt
Outdated
Show resolved
Hide resolved
...ces-fido/core/src/main/kotlin/org/microg/gms/fido/core/protocol/msgs/AuthenticatorGetInfo.kt
Outdated
Show resolved
Hide resolved
...ces-fido/core/src/main/kotlin/org/microg/gms/fido/core/protocol/msgs/AuthenticatorGetInfo.kt
Outdated
Show resolved
Hide resolved
...o/core/src/main/kotlin/org/microg/gms/fido/core/protocol/msgs/AuthenticatorMakeCredential.kt
Outdated
Show resolved
Hide resolved
mar-v-in
requested changes
Mar 12, 2026
...rc/main/java/com/google/android/gms/fido/fido2/api/common/PublicKeyCredentialDescriptor.java
Outdated
Show resolved
Hide resolved
Safari requires it to be present
- Rename bluetooth->hybrid (bluetooth is actually still missing implementation) - Drop custom CBOR implementation - Drop custom credential selector (we already had one) - Allow NFC/USB keys to be used through hybrid authentication
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FIDO adds cross-device (hybrid) login.
Scene 1: Log in to local applications using other device keys by scanning the local device's QR code.
Scene 2: Scan the key QR code on another device using the Google App to log in using your device's key.