Skip to content

Conversation

@LeoniePhiline
Copy link

@LeoniePhiline LeoniePhiline commented Dec 14, 2025

  • nRF52833 link led to "Not Found" (see screenshot below) and was corrected.
  • nRF51822 link working but outdated, and was simplified.
image

- nRF51822 link was correct but could be simplified.
- nRF52833 link led to "Not Found" and was corrected.
Copy link
Contributor

@microbit-carlos microbit-carlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch finding these dead URLs and thanks for the PR @LeoniePhiline!

As the links are meant to point to the datasheets (even if the nrf51 one pointed to a product page) we can take the opportunity to update them to those specific pages.

Are you happy to update the URLs to the ones listed in the review? I can also push the changes directly to the PR before merging it if you prefer.

- [KL26 datasheet](http://www.nxp.com/webapp/search.partparamdetail.framework?PART_NUMBER=MKL26Z128VFM4)

- [nRF52833 datasheet](https://infocenter.nordicsemi.com/index.jsp?topic=%2Fstruct_nrf52%2Fstruct%2Fnrf52833.html&cp=3_1)
- [nRF52833 datasheet](https://www.nordicsemi.com/Products/nRF52833)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can link to this page listing the all the nrf52833 datasheet versions:
https://docs.nordicsemi.com/bundle/ps_nrf52833/page/keyfeatures_html5.html

Suggested change
- [nRF52833 datasheet](https://www.nordicsemi.com/Products/nRF52833)
- [nRF52833 datasheet](https://docs.nordicsemi.com/bundle/ps_nrf52833/page/keyfeatures_html5.html)

- [nRF52833 datasheet](https://www.nordicsemi.com/Products/nRF52833)

- [nRF51822 datasheet](https://www.nordicsemi.com/eng/Products/Bluetooth-low-energy/nRF51822)
- [nRF51822 datasheet](https://www.nordicsemi.com/Products/nRF51822)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case we can link to the nRF51822 datasheet directly:
https://docs.nordicsemi.com/bundle/nRF51-Series/resource/nRF51822_PS_v3.4.pdf

Suggested change
- [nRF51822 datasheet](https://www.nordicsemi.com/Products/nRF51822)
- [nRF51822 datasheet](https://docs.nordicsemi.com/bundle/nRF51-Series/resource/nRF51822_PS_v3.4.pdf)

@LeoniePhiline
Copy link
Author

Sure! I'll update the links, probably tomorrow or during the weekend.

Thanks for your suggestions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants