Skip to content

EvidentIX85Win: Query ZDC offset lens min and max for each different objective.#948

Merged
nicost merged 2 commits into
micro-manager:mainfrom
nicost:IX85_Offset
May 27, 2026
Merged

EvidentIX85Win: Query ZDC offset lens min and max for each different objective.#948
nicost merged 2 commits into
micro-manager:mainfrom
nicost:IX85_Offset

Conversation

@nicost
Copy link
Copy Markdown
Member

@nicost nicost commented May 27, 2026

No description provided.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Evident IX85 (Windows) offset-lens handling to use objective-dependent (nosepiece-position-dependent) ZDC offset-lens travel limits queried from the hardware, rather than fixed compile-time constants.

Changes:

  • Update the offset-lens “range” command tag to GABRANGE.
  • Add a hub query path (QueryOffsetLensRange(nosepiecePos)) that retrieves and stores per-objective offset-lens min/max steps in the shared model.
  • Use the model’s per-objective limits for clamping and for EvidentOffsetLens::GetLimits().

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
DeviceAdapters/EvidentIX85Win/EvidentProtocolWin.h Changes the protocol command tag for querying offset-lens range.
DeviceAdapters/EvidentIX85Win/EvidentIX85Win.cpp Clamps offset-lens moves and reports limits using model-stored, hardware-reported bounds.
DeviceAdapters/EvidentIX85Win/EvidentHubWin.h Declares a new hub helper to query offset-lens range per nosepiece position.
DeviceAdapters/EvidentIX85Win/EvidentHubWin.cpp Initializes default limits, queries range after offset-lens query, and refreshes range on nosepiece change notifications.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread DeviceAdapters/EvidentIX85Win/EvidentHubWin.cpp Outdated
Comment thread DeviceAdapters/EvidentIX85Win/EvidentHubWin.cpp Outdated
@nicost nicost merged commit c1d1a4c into micro-manager:main May 27, 2026
2 checks passed
@nicost nicost deleted the IX85_Offset branch May 27, 2026 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants