DeviceBase: Remove OnXYStagePropertyChanged callbacks in code setting the XY stage positions. #807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the XY stage positions. This is undoing commit d1962c6 which I made myself in 2011. Getting this callback automatically, even when the stage is not anywhere near the desired position has become annoying and confusing.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes automatic OnXYStagePositionChanged callbacks that were triggered when setting XY stage positions, reverting behavior from a 2011 commit. The change addresses confusion caused by callbacks firing before the stage reaches its target position.
- Removes automatic position callbacks from
SetPositionUmandSetRelativePositionUmmethods - Eliminates internal tracking of xPos_ and yPos_ member variables when setting positions
- Simplifies position-setting methods to directly return results without intermediate state updates
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…caching ox x and y positions for that purpose, but remove OnXYSTagePositionChanged callbacks.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is undoing commit d1962c6 which I made myself in 2011.
Getting this callback automatically, even when the stage is not anywhere near the desired position has become annoying and confusing.
Closes #806. Will open another PR for the addition of a function to report whether or not the stage uses callbacks.