Open
Conversation
- Add structured Maestro E2E test files with numerical prefixes - Set up secure credential management for tests - Implement pre-commit hooks to prevent secrets leakage - Add comprehensive documentation for E2E testing - Configure screenshots organization in dedicated folders - Add npm scripts for running specific test scenarios - Add support for tests with manual system dialog confirmation
This commit adds a token-based approach for E2E testing with OIDC authentication: - New test flow that injects OIDC tokens directly into the app - Helper script that retrieves tokens from oidc-agent - Detailed documentation for setup and usage - Updated env.example.json to support token-based configuration - NPM script for easily running token-based tests This approach improves E2E testing by: - Bypassing WebView-based authentication completely - Eliminating the need for manual interaction with system dialogs - Removing the need to store passwords in configuration files - Making tests more reliable and faster 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
|
Coverage after merging feature/e2e-tests into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Features
Token-based Authentication Approach
The new token-based approach:
Test Plan
npm run test:e2e:loginnpm run test:e2e:themenpm run test:e2e:screenshotsnpm run test:e2e:login:confirmationnpm run test:e2e:oidc:token(requires oidc-agent setup)🤖 Generated with Claude Code