Improve quantity and quality of matches #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before: Found up to maxmatches for each case, then tried to find up to maxmatches for the next case. So some cases would go unmatched because the only available control was used as an nth match for a previous case. Now: Find a first match for each case, then a second, etc, up to maxmatches. So any case that can have at least one match gets at least one.
When multiple controls exist within the caliper tolerance, always select the closest one (in terms of sum of squared errors)
…riable does not exist
… add corresponding test
See if this resolves: mkdir: cannot create directory ‘/usr/local/stata16’: Permission denied https://github.com/michaelstepner/calipmatch/actions/runs/3228506690/jobs/5284691399
This reverts commit 28c0b66.
…est and organized tests in test file
This reverts commit a069d74.
The wrong return code was being tested for. The error was being caused by the syntax statement before -calipmatch-, rather than -calipmatch- itself. This changed in 57613d3
The wrong return code was being tested for. The error was being caused by the syntax statement before -calipmatch-, rather than -calipmatch- itself. This changed in 57613d3
- Update comments - Recategorize / rename categories - Simplify tests for 'perfect match per case' - Set seeds only once
New Unit Tests
michaelstepner
force-pushed
the
develop
branch
from
c39cb0a to
2dc40ca
Compare
* Automatically update embedded sthlp in README
* Bugfix detached HEAD
```
[detached HEAD e8fbcab] README: update embedded calipmatch.sthlp
1 file changed, 144 deletions(-)
fatal: You are not currently on a branch.
To push the history leading to the current (detached HEAD)
state now, use
git push origin HEAD:<name-of-remote-branch>
```
* README: update embedded calipmatch.sthlp
* Bugfix replacement of sthlp in README
* README: update embedded calipmatch.sthlp
* Whitespace changes in code
* Bugfix: detection of changes
* GHA: Update names of steps
Co-authored-by: OppInsights-Bot <info@opportunityinsights.org>
* Upgrade to Stata 17 * Make stata version configurable by environment variable * Install Stata 16 instead * Use Stata 16 for all workflows
* GHA action version upgrades and indentation fix * GHA: check if version number in PR has incremented * Fix missing syntax in GHA * GHA: bugfix paths * Fix nested variable names * Assign value to variable with name containing var Ref: https://stackoverflow.com/questions/13716607/creating-a-string-variable-name-from-the-value-of-another-string * Allow single-digit day in date * WIP: update last-updated date to today * WIP: try removing second match parameter * WIP: bugfix sed * WIP: remove all match parameters from substitution * WIP: sed substitution on specific line * WIP: simplify regular expression * Modify date replacement * WIP debug date and add package date update * Fix calipmatch.pkg name * Fix package date name * Fix package file name * Separate code to update pkg date * Simplify date update in pkg file * Push date updates to repo * Bugfix: push from the PR directory * Update 'last updated' dates * Add pkg file as trigger for version_increment GHA * Bugfix sed syntax -iE was treating 'E' as the suffix for a backup file also, we no longer need -E because we're not using regex extended syntax * Tidy step names Co-authored-by: jethaaly <alykhan.jetha@mail.utoronto.ca> Co-authored-by: OppInsights-Bot <info@opportunityinsights.org>
* Add test: minimize sum of squares * Fix test: minimize sum of squares * Style/formatting changes Co-authored-by: Michael Stepner <software@michaelstepner.com>
* GHA: auto update README installation instructions * README: update installation instructions * Bugfix escaping in multiline string * Actually insert README installation instructions * README: update installation instructions Co-authored-by: OppInsights-Bot <info@opportunityinsights.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements an improved greedy algorithm, which is slightly more computationally demanding but finds more matches and better matches.
Details of the change in algorithm are described in the help file.