Skip to content

Refactor log file creation in SetLogFile procedure #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michaelJustin merged 2 commits into from
Jun 20, 2026
Merged

Refactor log file creation in SetLogFile procedure #23

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
00ee460
Refactor log file creation in SetLogFile procedure
michaelJustin Jun 20, 2026
b1a1f71
Apply suggestions from code review
michaelJustin Jun 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 4 additions & 11 deletions src/main/Log4D.pas
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3042,7 +3042,6 @@ constructor TLogFileAppender.Create(const Name, FileName: string;
procedure TLogFileAppender.SetLogFile(const Name: string);
var
strPath: string;
f : TextFile;
begin
CloseLogFile;
FFileName := Name;
Expand All @@ -3057,20 +3056,14 @@ procedure TLogFileAppender.SetLogFile(const Name: string);
begin
// Check if directory exists
strPath := ExtractFileDir(FFileName);
if (strPath <> '') and not DirectoryExists(strPath) then
if (strPath <> '') and not DirectoryExists(strPath) then
ForceDirectories(strPath);

//FIX 04.10.2006 MHoenemann:
// SysUtils.FileCreate() ignores any sharing option (like our fmShareDenyWrite),
// Creating new file
AssignFile(f, FFileName);
try
ReWrite(f);
finally
CloseFile(f);
end;
// now use this file
FStream := TFileStream.Create(FFileName, fmOpenReadWrite or fmShareDenyNone);
// Creating new file directly via TFileStream with fmCreate, which truncates/creates
// the file and gives us the stream with the desired share mode in one step.
FStream := TFileStream.Create(FFileName, fmCreate or fmShareDenyNone);
end;
WriteHeader;
end;
Expand Down
Loading