Update main ahpn branch with upstream main

[miceno]

No description provided.

[Copilot]

Pull request overview

This PR updates the main AHPN branch with changes from the upstream main branch, primarily addressing PHP 8.2 compatibility issues related to deprecated dynamic properties and updating the ADOdb database library.

Key changes include:

• Declaring dynamic properties explicitly across test classes to comply with PHP 8.2 requirements
• Updating ADOdb library from v5.22.5 to v5.22.7 with PHP 8.2 compatibility fixes
• Minor string interpolation syntax updates for consistency

Reviewed changes

Copilot reviewed 235 out of 235 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
Test class files (watermark, useralbum, etc.)	Added explicit public property declarations to prevent PHP 8.2 deprecation warnings
ADOdb library files	Updated to v5.22.7 with bug fixes and PHP 8.2 compatibility improvements
Core module classes	Added dynamic property declarations for PHP 8.2 compatibility
String interpolation updates	Changed "${var}" to "{$var}" syntax for consistency
PostgreSQL storage class	Added null check in convertBitsToInt() and updated INSERT statement generation

Comments suppressed due to low confidence (13)

modules/rating/test/phpunit/RatingCallbacksTest.class:1

• Corrected spelling of 'php' (missing 'p' character).
  modules/ffmpeg/test/phpunit/FfmpegToolkitTest.class:1
• Missing 'in' between 'properties' and 'php'.
  modules/ffmpeg/test/phpunit/AdminFfmpegControllerTest.class:1
• Type declaration array is inconsistent with other property declarations in the codebase which don't use type hints. Remove the type hint for consistency.
  modules/core/test/phpunit/OptimizeDatabaseTaskTest.class:1
• Corrected spelling of 'dynamic' (typo: 'dynanic').
  modules/core/test/phpunit/EventLogHelperTest.class:1
• Corrected spelling of 'php' (missing 'p' character).
  modules/core/test/phpunit/UtilitiesTest.class:1
• Corrected spelling of 'deprecated' (typo: 'deprecatced').
  modules/core/test/phpunit/ItemAddControllerTest.class:1
• Corrected spelling of 'dynamic' (typo: 'dynamci').
  modules/core/test/phpunit/CreateThumbnailOptionTest.class:1
• Remove trailing whitespace on this line.
  modules/core/test/phpunit/AlbumTest.class:1
• The class declaration was reformatted by adding a space before the opening brace. While this is a valid fix, ensure it's consistent with the project's coding standards.
  modules/core/classes/GalleryDynamicAlbum.class:1
• The comment should use 'deprecated' instead of 'deprecate' for consistency with other similar comments.
  modules/core/test/phpunit/AdminCoreControllerTest.class:1
• Inconsistent indentation - this comment uses spaces while surrounding code uses tabs. Should use tabs for consistency.
  lib/pear/HTMLSax3.php:1
• Type declaration array is inconsistent with the rest of the codebase which uses var declarations without type hints. For consistency, this should be var $attrs; instead.
  lib/adodb/perf/perf-oci8.inc.php:1
• The parent class name changed from ADODB_perf to adodb_perf. Verify this is the correct class name and matches the actual parent class definition.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.