Skip to content

Add support for SimpleImage#6

Open
Heriberto-Juarez wants to merge 5 commits into
miadabdi:mainfrom
Heriberto-Juarez:main
Open

Add support for SimpleImage#6
Heriberto-Juarez wants to merge 5 commits into
miadabdi:mainfrom
Heriberto-Juarez:main

Conversation

@Heriberto-Juarez

Copy link
Copy Markdown

Fixing a typo and adding support to simple image.

@Heriberto-Juarez

Copy link
Copy Markdown
Author

Now Im also adding support for linkTool

@miadabdi

miadabdi commented Sep 6, 2022

Copy link
Copy Markdown
Owner

@Heriberto-Juarez
I'm sorry, I am having a confusion over changes regarding simple-image,
Didn't this package support simple-image already?
I mean, I am suspecting what you mean by "adding support to simple image" is just changing the package to support image and simple-image at the same time.

Changes made for link-tool seems fine, I just need some explanation on what happened with "images part" of this pull request.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants