Open
Conversation
- Introduced a new pre-deploy filter to handle jobs annotated for pre-deploy execution. - Added multiple test cases to validate the filtering logic for pre-deploy jobs. - Created example ConfigMap and Deployment resources for testing purposes. - Implemented various pre-deploy job configurations, including optional and failing jobs. - Enhanced the test suite with comprehensive tests for pre-deploy job extraction and filtering.
…ces based on annotations - Deleted the predeployfilter.go and predeployfilter_test.go files, which contained logic for filtering pre-deploy jobs based on annotations. - Removed associated test data files for pre-deploy jobs, including optional and custom annotation jobs. - Added comprehensive tests for filtering and executing pre-deploy jobs in predeployjob_test.go, ensuring correct behavior for various scenarios.
…and improved error reporting
…atches correctly (skip all resources)
…sion test for timeout scenarios
…tered job, to make this feature more extendible
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR is for?
This PR is intended to enhance the
deploycommand adding the execution of Jobs marked as pre-deploy jobs before the main deployment pipeline.This feature allows you to run initialization or validation tasks (such as database migrations, secret provisioning,
or health checks) prior to deploying your main workloads.