Tear out the vendored docx editor packages#170
Merged
Conversation
The fast-follow plan from the first real drafting sessions on the headless-redline foundation: a condensed review surface with per-change accept/reject in-app (feasible as ~50 lines of our own revision surgery), read_draft exposing the full review state (pending redlines + comments inline), overlap-aware editing of paragraphs carrying attorney revisions (shrinking today's blunt refusal to true conflicts), and re-lock.
The app has been fully off the editor since PR #169 (headless redlining; Word is the review surface) — this removes the now-unimported packages wholesale: docx-editor-core, docx-editor-agents, docx-editor-react, the editor's 53 binary test fixtures (the USPTO office action stays — it's the redlining suites' corpus), and the lint/knip exemptions that existed only for them. CLAUDE.md's editor section is replaced by the headless-redlining model (the adapter's measured guards, the dance protocol, the draft tools, the unlock-in-place rules); SCRATCHPAD's editor-era backlog is pruned to the items that survive translation to the new world. Test count drops from ~1,770 to 59 — everything deleted tested deleted code.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The mechanical follow-up to #169: deletes the three vendored editor packages (
docx-editor-core,docx-editor-agents,docx-editor-react, ~134k LOC) and the editor's 53 binary test fixtures. Nothing has imported them since #169 merged — Patrick edits.docxheadlessly and Word is the review surface.Also in here
living-docs/draft-review-panel.md— the researched fast-follow from the first real drafting sessions: condensed review view with in-app per-change accept/reject (feasible as our own revision surgery),read_draftexposing the full review state (pending redlines + comments inline), overlap-aware editing of paragraphs carrying attorney revisions, re-lock.e2e/fixtures/uspto-office-action.docxstays — it's the redlining suites' real-world corpus.Testing
pnpm checkclean;bun test59 pass (the ~1,700 deleted tests tested deleted code — the surviving suites are Patrick's own: the redline adapter + dance against the real USPTO fixture, chart merge, citation matchers, context assembly, unlock semantics).Merge gate
Hold for the Windows Word checkpoint — open a Patrick-redlined document in real desktop Word (redlines accept/reject cleanly, comments render, no repair prompt). LibreOffice + Google Docs have passed; Word is the remaining validation.