refactor(editor): delete dead --color-docx-* @theme mappings from the host (styling Phase 3)#165
Merged
Merged
Conversation
… the host The frontend index.css @theme block mapped 27 --color-docx-* utilities from the editor's --docx-* tokens, ostensibly so editor components could use bg-docx-*/ text-docx-* classes. But nothing uses them: the editor styles via raw var(--docx-*) (painter, overlays, its CSS) + shadcn utilities from @patrick/ui. Zero -docx-* utility usages anywhere. So delete the mappings rather than relocate dead config into the editor. The host no longer hand-wires any editor token — the goal of this phase, better achieved by removal. (A missing Tailwind utility is a silent no-op, not a build error, so this is guarded by the zero-usage grep, not the Vercel build.)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 3 of the styling consolidation. The plan was to relocate the host's editor-token
@thememappings into the editor; investigating, they're dead, so this deletes them instead.What
The frontend
index.css@theme inlineblock mapped 27--color-docx-*→var(--docx-*)entries, generatingbg-docx-*/text-docx-*/border-docx-*utilities "the editor components use." Nothing uses them — the editor styles via rawvar(--docx-*)(painter, overlays, its own CSS) + shadcn utilities from@patrick/ui. Deleted the mappings + their comment.Why delete, not relocate
Moving dead config into the editor would just clutter it. Deleting achieves this phase's goal — the host stops hand-wiring editor tokens — and removes junk. The
--docx-*token definitions (tokens.css) and the@sourcescan are untouched.Safety
-docx-utility usages anywhere (bg/text/border/ring/…-docx-*), static; dynamicbg-docx-${x}wouldn't be Tailwind-generated regardless, so there's no working usage to break.pnpm checkgreen ·bun test1739 pass.