refactor(editor): split stylesheets by concern — tokens + revisions (styling Phase 2b)#164
Merged
Merged
Conversation
Carve the two entry stylesheets into concern files, wired via @import aggregators so consumers are unchanged (frontend still imports editor.css; hidden-prose-mirror still imports prosemirror.css): - tokens.css — the --docx-* palette (light + dark), out of editor.css. 'Where do I change an editor colour' now has one obvious home. - revisions.css — the tracked-change structural cues, out of prosemirror.css. editor.css @imports tokens.css; prosemirror.css @imports revisions.css. Verified behaviour-preserving by diffing sorted non-comment lines against the pre-split files (no rule lost or added).
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 2b of the styling consolidation. Pure content reorganization, no rule changed.
What
Carve the two entry stylesheets into concern files, wired via
@importaggregators so consumers are unchanged:tokens.css— the--docx-*palette (light + dark), out ofeditor.css. One obvious home for "where do I change an editor colour."revisions.css— the tracked-change structural cues, out ofprosemirror.css.editor.css@imports tokens.css;prosemirror.css@imports revisions.css.Safety (behaviour-preserving, proven)
@importsits at file top, so revisions.css loads before the painter rules (was mid-file). Verified none of the 12.ep-revision-*/.layout-revision-*classes appear in the painter stylesheet → no shared targets → order immaterial. Token definitions likewise don't double-define.pnpm checkgreen (biome accepts the@importplacement) ·bun test1739 pass · Vercel rebuilds the CSS graph (confirms the@imports resolve + bundle).