chore(tooling): Centralize oxlint/oxfmt config at workspace root#152
Merged
chore(tooling): Centralize oxlint/oxfmt config at workspace root#152
Conversation
Move oxlint and oxfmt configuration to repository root and reference it from both TS packages via -c flag. Enable type-aware lint with denyWarnings so warnings fail CI, and add oxlint-tsgolint to the workspace catalog.
mhiro2
changed the title
…e-aware lint findings Reformat TypeScript, esbuild configs, HTML, and CSS via oxfmt with the new root config, and address type-aware findings surfaced by oxlint-tsgolint: prefer Array.prototype.toSorted over [...arr].sort, replace generic emitViewerEvent with unknown detail, add exhaustive switch defaults, and rename a shadowed local in minimap. Regenerate the bundled viewer scripts under crates/relune-render-html/src/js to match the reformatted sources.
mhiro2
force-pushed
the
chore/oxlint-oxfmt-root-config
branch
from
fd0caf5 to
1ef2eaa
Compare
Code Metrics Report
Details | | main (dc2f606) | #152 (ef08e77) | +/- |
|---------------------|----------------|----------------|------|
| Coverage | 94.4% | 94.4% | 0.0% |
| Files | 100 | 100 | 0 |
| Lines | 36742 | 36742 | 0 |
| Covered | 34704 | 34704 | 0 |
| Test Execution Time | 1m35s | 1m35s | 0s |Reported by octocov |
Schema reviewTip ✅ No risk findings — schema changes look safe to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-cflag from each package script.denyWarnings: trueso warnings fail CI, and addoxlint-tsgolintto the workspace catalog and the dependabot oxc group.singleQuote,sortImports) across the frontend sources and address the type-aware findings surfaced by the new configuration.Changes
.oxlintrc.jsonand.oxfmtrc.json, drop the per-crate.oxfmtrc.jsonc, and updateplaygroundandrelune-render-htmlpackage scripts to point at the shared configs.oxlint-tsgolintinpnpm-workspace.yamland group it with the existing oxc dependabot updates.Array.prototype.toSorted, replace the unused generic onemitViewerEventwithunknown, add exhaustive switch defaults, and rename a shadowed local inminimap.ts.crates/relune-render-html/src/jsto match the reformatted sources.