fix(web): show mobile doc selector when no KB doc is selected#84
Merged
Merged
Conversation
- Add MobileDocTrigger component reused by viewer/editor - Render trigger in KnowledgeBase fallback branches so mobile users can reach the sheet from "Select a doc" and "No KB yet" states - Refactor KnowledgeDocViewer/Editor to consume the shared component - Update web/CLAUDE.md Mobile Knowledge Base architecture
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After CTXMAX-476 made the Knowledge Base tab mobile-responsive, mobile users opening the KB tab with no doc selected saw "Select a doc" with no way to open the doc selector — the desktop sidebar is hidden on mobile (
hidden md:flex) and the only sheet trigger lived insideKnowledgeDocViewer/KnowledgeDocEditor, which only render when a doc IS selected. Same dead-end for the "No knowledge base docs yet." fallback when the project has no built KB — the Refresh button is in the unreachable sidebar.Changes
MobileDocTriggercomponent (open-book icon + label + chevron,md:hidden).KnowledgeBase.tsxso mobile users can always reach theMobileDocSheet.KnowledgeDocViewerandKnowledgeDocEditorto consume the shared component (dedupes ~20 lines of SVG markup per call site, drops both files in line with the ~150-line guideline).web/CLAUDE.mdMobile Knowledge Base architecture table and Behaviour subsection.Test plan
cd web && npm run lintcleancd web && npm run buildclean