Skip to content

Check for invalid filter index in windows_kevent_copyout #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arr2036 merged 2 commits into from
Sep 18, 2025
Merged

Check for invalid filter index in windows_kevent_copyout #163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a91b98e
Check for invalid filter index in windows_kevent_copyout
timwoj Sep 18, 2025
1a9e49f
Bump Windows CMake generator to Visual Studio 2022
timwoj Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/ci-windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,8 @@ jobs:
- name: Configure build system
run: |
cmake --version
cmake -S . -B build_x64 -A x64 -G "Visual Studio 16 2019" -DSTATICLIB=ON -DCMAKE_BUILD_TYPE=Release -DCMAKE_VERBOSE_MAKEFILE=ON
cmake -S . -B build_x64 -A x64 -G "Visual Studio 17 2022" -DSTATICLIB=ON -DCMAKE_BUILD_TYPE=Release -DCMAKE_VERBOSE_MAKEFILE=ON

- name: Build libkqueue
run: |
cmake --build build_x64 --target install --config Release --parallel 1

10 changes: 8 additions & 2 deletions src/windows/platform.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,11 +134,17 @@ windows_kevent_copyout(struct kqueue *kq, int nready,
{
struct filter *filt;
struct knote* kn;
int rv, nret;
int rv, nret, filt_index;

//FIXME: not true for EVFILT_IOCP
kn = (struct knote *) iocp_buf.overlap;
filt = &kq->kq_filt[~(kn->kev.filter)];
filt_index = ~(kn->kev.filter);
if (filt_index < 0 || filt_index >= EVFILT_SYSCOUNT) {
dbg_puts("bad filter index in windows_kevent_copyout");
return 0;
}
filt = &kq->kq_filt[filt_index];

rv = filt->kf_copyout(eventlist, nevents, filt, kn, &iocp_buf);
if (unlikely(rv < 0)) {
dbg_puts("knote_copyout failed");
Expand Down