Skip to content

fix: prevent negative listener count in AnimatedColor #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mhdamirhamza wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: prevent negative listener count in AnimatedColor #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions packages/react-native/Libraries/Animated/nodes/AnimatedColor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,14 @@ export default class AnimatedColor extends AnimatedWithChildren {
nativeColor: ?NativeColorValue;

_suspendCallbacks: number = 0;
_listeners: {
[key: string]: {
r: string,
g: string,
b: string,
a: string,
},
} = {};

constructor(valueIn?: InputValue, config?: ?AnimatedColorConfig) {
super(config);
Expand Down Expand Up @@ -171,6 +179,35 @@ export default class AnimatedColor extends AnimatedWithChildren {
}
}

addListener(callback: ColorListenerCallback): string {
const id = String(Math.random());
const jointCallback = () => callback(this.__getValue());
this._listeners[id] = {
r: this.r.addListener(jointCallback),
g: this.g.addListener(jointCallback),
b: this.b.addListener(jointCallback),
a: this.a.addListener(jointCallback),
};
return id;
}

removeListener(id: string): void {
if (!this._listeners[id]) {
// Already removed (e.g. after __detach / removeAllListeners) — safe no-op
return;
}
this.r.removeListener(this._listeners[id].r);
this.g.removeListener(this._listeners[id].g);
this.b.removeListener(this._listeners[id].b);
this.a.removeListener(this._listeners[id].a);
delete this._listeners[id];
}

removeAllListeners(): void {
Object.keys(this._listeners).forEach(id => this.removeListener(id));
this._listeners = {};
}

/**
* Directly set the value. This will stop any animations running on the value
* and update all the bound properties.
Expand Down