Use service=s3 by default for DigitalOcean and Linode#79
Open
twilligon wants to merge 1 commit intomhart:masterfrom
Open
Use service=s3 by default for DigitalOcean and Linode#79twilligon wants to merge 1 commit intomhart:masterfrom
service=s3 by default for DigitalOcean and Linode#79twilligon wants to merge 1 commit intomhart:masterfrom
Conversation
A few services expect the `service` parameter to be set to `s3` where this is not currently inferred, such that "default" aws4fetch use fails with authentication errors. We already handle this case for R2 and B2, but we were missing Linode Object Storage and DigitalOcean Spaces: mhart#15 twilligon/git-lfs-s3-proxy#10 Handle `service` as we do for R2 and B2 so aws4fetch works by default. Also, add virtual-host and path-style URL tests for both providers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few services expect
service=s3when this is not currently inferred by aws4fetch, such that they don't work "by default":This detects their hostnames (
*.digitaloceanspaces.comand*.linodeobjects.com) and follows the existing pattern for R2 and B2 detection to set theserviceparameter. Also added test coverage for both providers with virtual-host and path-style URLs. I think this is all correct, LMK if it needs edits!