refactor a parameter for SetCellUsing and SetPropertyUsing#213
Open
andywu188 wants to merge 5 commits intomganss:masterfrom
Open
refactor a parameter for SetCellUsing and SetPropertyUsing#213andywu188 wants to merge 5 commits intomganss:masterfrom
andywu188 wants to merge 5 commits intomganss:masterfrom
Conversation
Contributor
andywu188
commented
Aug 26, 2022
- Solve the problem that SetCellUsing and SetPropertyUsing parameters are not named and ambiguous.
- Improved support for parameters that can perform multiple property value calculations
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #213 +/- ##
==========================================
+ Coverage 94.29% 95.27% +0.97%
==========================================
Files 11 13 +2
Lines 1384 1417 +33
Branches 203 203
==========================================
+ Hits 1305 1350 +45
+ Misses 51 39 -12
Partials 28 28 ☔ View full report in Codecov by Sentry. |
Owner
|
Thanks. There are some uncovered lines still, though. |
Contributor
Author
|
already updated |
Contributor
Author
|
I recommend making the other SetCellUsing and SetPropertyUsing methods obsolete. |
Owner
Can you add this to the PR? |
Contributor
Author
|
already updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.