The SaveAsync taking a stream is failing because the Workbook.Save is…#125
The SaveAsync taking a stream is failing because the Workbook.Save is…#125MKleisinger wants to merge 1 commit intomganss:masterfrom
Conversation
… closing the created memory stream before it can copy the data into the users passed in stream. Adding a memory stream overriding close will fix this issue.
Codecov Report
@@ Coverage Diff @@
## master #125 +/- ##
==========================================
- Coverage 93.79% 93.67% -0.13%
==========================================
Files 9 9
Lines 1193 1201 +8
Branches 171 172 +1
==========================================
+ Hits 1119 1125 +6
- Misses 47 48 +1
- Partials 27 28 +1
Continue to review full report at Codecov.
|
|
Tests are failing because the implemented non-closing stream is not being closed in any tests. |
|
I can't repro the failure. The |
|
The way I was able to repro it was to attempt to write the stream to an excel file. The excel file would be created; however, the worksheet was blank. When debugging I noticed that the stream had already been closed. |
|
Can you post a code snippet that shows the issue? |
… closing the created memory stream before it can copy the data into the users passed in stream. Adding a memory stream overriding close will fix this issue.