feat: wrap buffer in arc for easy shared ownership#45
Open
Conversation
Clean up unnecessary code and simplifying the `WeightLoader` struct
mfuntowicz
reviewed
Mar 12, 2026
| const size_t staging_size = HMLL_URING_QUEUE_DEPTH * HMLL_URING_BUFFER_SIZE; | ||
|
|
||
| unsigned char *arena = hmll_alloc(staging_size, device, HMLL_MEM_STAGING); | ||
| if (!arena) { |
Collaborator
Author
There was a problem hiding this comment.
ah yes sorry left over from debugging!
McPatate
force-pushed
the
feat/wrap_buffer_in_arc_for_easy_sharing
branch
from
c3491bf to
c67e7c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
will rebase main after #43 is merged