Fix tests build on modern glibc by disabling Catch2 POSIX signals#323
Open
jlcordeiro wants to merge 1 commit into
Open
Fix tests build on modern glibc by disabling Catch2 POSIX signals#323jlcordeiro wants to merge 1 commit into
jlcordeiro wants to merge 1 commit into
Conversation
by disabling Catch2 POSIX signals
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a build failure in the test suite on systems with modern glibc (>= 2.34).
Catch2 v2 uses
SIGSTKSZas a compile-time constant, but newer glibc versions no longer guarantee this, causing compilation errors like:Related issues:
#294
redpanda-data/redpanda#4298
Tested both on ubuntu 20.04 (old glibc, build worked already) and 24.04 (new glibc, tests build failed)