feat(images): add server image endpoints and client hook; prefer server image, fall back to url#2
Open
RagnaJDC wants to merge 1 commit into
Open
feat(images): add server image endpoints and client hook; prefer server image, fall back to url#2RagnaJDC wants to merge 1 commit into
RagnaJDC wants to merge 1 commit into
Conversation
…er-hosted images in MvpTracker
mfcano
reviewed
Nov 24, 2025
| import urllib.request | ||
|
|
||
|
|
||
| def get_image(req: https_fn.Request, headers: dict, image_name: str) -> https_fn.Response: |
Owner
There was a problem hiding this comment.
if image not available in bucket, dont return 404. fetch image from RMS and call save_image on it. then return the bucket URL. @RagnaJDC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…er-hosted images in MvpTracker