Use broad notification methods during initialize()#116
Open
ptarjan wants to merge 1 commit intomezz64:masterfrom
Open
Use broad notification methods during initialize()#116ptarjan wants to merge 1 commit intomezz64:masterfrom
ptarjan wants to merge 1 commit intomezz64:masterfrom
Conversation
initialize() was calling get_event_triggers() with the narrow default
of {'center', 'HTTP'}, which misses events on NVRs that use 'record',
'email', or 'beep' notification methods. This forced the Home Assistant
integration to make a duplicate get_event_triggers() call with the
broader set, adding an extra ~10s network round-trip during startup.
Use VALID_NOTIFICATION_METHODS (which includes all five methods) in
the initial call so all events are discovered on the first fetch.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
initialize()was callingget_event_triggers()with the narrow default of{'center', 'HTTP'}, which misses events on NVRs that userecord,email, orbeepnotification methodsget_event_triggers()call with the broader set, adding an extra ~10s network round-trip during startupVALID_NOTIFICATION_METHODS(all five methods) in the initial call so all events are discovered on the first fetchTest plan
python -m pytest test/test_hikvision.py)🤖 Generated with Claude Code