Open
Conversation
Contributor
|
Very cool! It looks like this PR is missing your changes. Let me know in the chat if you need help. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my first time doing a pull request, ever 😅
This commit makes the wait screen show up while loading. When the level is done loading the screen stays for however many seconds there are left. If the loading takes more than two seconds it should disappear instantly.
Now there are some caveats:
createPlayerProgressLayerfunction to rather take player and levelname than the whole level as an argument (the level isn't available before loading).createDummyDashboardLayerfor the waitscreen as thecreateDashboardLayerneeds access to the level to get ahold of the leveltimer. This could be done in other ways too, like adding the dashboard after the level is loaded. This would not be as seemless unless you are hosting the game on your own computer with little to no loading time.. There are probably better ways to do this, but i simply didn't have time to explore it.