fix: correctly map request body field by name #327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chebykinn
force-pushed
the
fix-body-mapping
branch
from
e0ea1eb to
9a685df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I've tried to fix issue #325, this PR should do it.
I've changed the field path to
body_rootif the current field is mapped by name, which allows setting RequestRootField ingengokit/http_transport.go, which is, in turn, checked in the template to select in which variable body will be deserialized.This fixes the issue in my cases, although maybe it should probably be worth hiding this fix under some option, at least for a few releases to keep backward compatibility.