deprecate(ModelOutput.quantity): mark quantity field as deprecated#199
Open
HaoZeke wants to merge 2 commits intometatensor:mainfrom
Open
deprecate(ModelOutput.quantity): mark quantity field as deprecated#199HaoZeke wants to merge 2 commits intometatensor:mainfrom
HaoZeke wants to merge 2 commits intometatensor:mainfrom
Conversation
HaoZeke
force-pushed
the
morfixes
branch
2 times, most recently
from
4d71dab to
e7e0aea
Compare
The quantity field on ModelOutput is no longer required for unit
conversion -- the unit parser now determines dimensions from the
expression itself. Setting a non-empty quantity emits a TORCH_WARN
deprecation notice from C++.
Input unit conversion in _convert_systems_units now gates on
requested.unit instead of requested.quantity, and the redundant
set_info("quantity", ...) call is removed.
- Remove quantity= parameter from ModelOutput calls in tests - Add pytest filterwarnings for the new deprecation warnings - Update conftest.py stderr filters for C++ TORCH_WARN output - Update C++ test warning handler to handle multiple warnings - Check unit info instead of removed quantity info in ASE tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The quantity field is no longer required for unit conversion since the unit parser determines dimensions from the expression itself.
Changes:
Contributor (creator of pull-request) checklist
Reviewer checklist