Skip to content

Migrate example#60

Draft
semohr wants to merge 3 commits intomainfrom
migrate-example
Draft

Migrate example#60
semohr wants to merge 3 commits intomainfrom
migrate-example

Conversation

@semohr
Copy link
Copy Markdown
Contributor

@semohr semohr commented Mar 11, 2026

Adds migration example to migrate all playlists from tidal to sportify or spotify to tidal.

While working on this example I noticed we desperately need #35 for this example to be usable. Currently each track insert is a single request which is fine for small update but when running on more than a few playlist we get into a rate limits really quickly. And an update which should be quick takes forever.

I would say we prioritize #35 and finish the example afterwards.

@github-actions
Copy link
Copy Markdown

Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry.

@pSpitzner pSpitzner mentioned this pull request Mar 11, 2026
8 tasks
@pSpitzner
Copy link
Copy Markdown
Contributor

That makes sense. Is this something we want before turning repo public?

This means we can almost merge #46 🤩
Last missing piece: "Tests are failing because of the get_playlist(name=...) inconsistency (None vs Raise) I think. Lets decide this and then fix it for all services."

@semohr
Copy link
Copy Markdown
Contributor Author

semohr commented Mar 11, 2026

That makes sense. Is this something we want before turning repo public?

I guess, I have already implemented the hard parts ;) #61

Last missing piece: "Tests are failing because of the get_playlist(name=...) inconsistency (None vs Raise) I think. Lets decide this and then fix it for all services."

I think we decided this already, add a get_or_raise method and adjust the other methods to not raise. Or is there something Im missing?

@pSpitzner
Copy link
Copy Markdown
Contributor

pSpitzner commented Mar 12, 2026

I guess, I have already implemented the hard parts ;) #61

lol.


Fair enough, ill take care of the get_or_raise PR then.
I like this as a general pattern (Im quite sure there are other lookups besides playlists/track ids that we dont have in scope right now)

got some hours on the train in the afternoon.

@semohr semohr force-pushed the enhanced_examples branch from 6ca5926 to 11c342d Compare March 13, 2026 16:35
@semohr semohr force-pushed the migrate-example branch 2 times, most recently from 8b63c44 to daac79a Compare March 13, 2026 16:42
@semohr semohr force-pushed the enhanced_examples branch from 11c342d to c31a541 Compare March 14, 2026 19:48
@semohr semohr changed the base branch from enhanced_examples to main April 3, 2026 10:54
@pSpitzner pSpitzner temporarily deployed to integration_tests April 3, 2026 11:58 — with GitHub Actions Inactive
@pSpitzner pSpitzner temporarily deployed to integration_tests April 3, 2026 11:58 — with GitHub Actions Inactive
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 3, 2026

Codecov Report

❌ Patch coverage is 44.44444% with 5 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
plistsync/services/spotify/api.py 0.00% 5 Missing ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants