IDEA: how to run multiple shoot monitor managers #82
+119
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vknabel
added
area: cluster-api
vknabel
force-pushed
the
multiple-shoot-monitor-managers
branch
from
92a0617 to
fa9fae1
Compare
vknabel
commented
Jan 19, 2026
| } | ||
| } | ||
|
|
||
| type MonitorManagerScheduler struct { |
Contributor
Author
There was a problem hiding this comment.
Naming and module still to debate.
vknabel
commented
Jan 19, 2026
| ref := deploymentRefTo(deploy) | ||
| log := m.log.WithValues("namespace", ref.namespace, "name", ref.name) | ||
|
|
||
| shootConfig, err := m.cc.ShootAccessHelper.RESTConfig(ctx) // TODO: adjust to fetch the kubeconfig |
Contributor
Author
There was a problem hiding this comment.
TODO: adjust to fetch the kubeconfig
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We plan on running one FCM to reconcile multiple namespaces #66
But to fully support our current feature set, we would be required to also observe the firewall monitors in dynamically allocated clusters. Setting one single kubeconfig via CLI flags does not cut it here.
Instead we would require FirewallDeployments to have a new (Shoot-)Kubeconfig-SecretRef. For every FirewallDeployment would then watch that secret to create a new Monitor Controller Manager.
These Monitor Controller Managers would need to be managed within the FCM.
Whenever:
The code of this PR currently only shows how we could approach the lifecycle of these monitor managers