Unified CI for Protocol, FaaS and Deploy#58
Closed
Priyanshu-u07 wants to merge 5 commits intometacall:masterfrom
Closed
Unified CI for Protocol, FaaS and Deploy#58Priyanshu-u07 wants to merge 5 commits intometacall:masterfrom
Priyanshu-u07 wants to merge 5 commits intometacall:masterfrom
Conversation
viferga
reviewed
Mar 29, 2026
| - name: Install deps with local Protocol | ||
| working-directory: faas | ||
| run: | | ||
| npm i |
Member
There was a problem hiding this comment.
Shouldn't you uninstall @metacall/protocol after this?
Contributor
Author
There was a problem hiding this comment.
Fixed.
The second npm i ./metacall-protocol-*.tgz overrides @metacall/protocol. But, adding it a better way.
| - name: Install deps with local Protocol | ||
| working-directory: deploy | ||
| run: | | ||
| npm i |
Contributor
Author
There was a problem hiding this comment.
Fixed.
The second npm i ./metacall-protocol-*.tgz overrides @metacall/protocol. But, adding it a better way.
Member
|
We have added workflow triggers for faas and deploy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This workflow creates three jobs.
First, it builds and packages the protocol into a
.tgzfile. Then, it runs two parallel jobs that test this package against FaaS and Deploy.This ensures any changes in Protocol are tested across both the repo FaaS and Deploy.