fix(call): prevent callFunction crash when request body is missing#139
Open
codxbrexx wants to merge 1 commit intometacall:masterfrom
Open
fix(call): prevent callFunction crash when request body is missing#139codxbrexx wants to merge 1 commit intometacall:masterfrom
callFunction crash when request body is missing#139codxbrexx wants to merge 1 commit intometacall:masterfrom
Conversation
Prevent callFunction from throwing when req.body is undefined or null. Also adds focused controller tests covering empty, object, and primitive request body inputs for Issue .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes by hardening
callFunctionagainst missing or invalid request bodies.Previously, the route could synchronously throw when
req.bodywasundefinedornull, becauseObject.values(req.body)was evaluated without a guard. This commonly affectsGETrequests and requests where Express does not populate the body.The fix safely extracts arguments only when
req.bodyis an object:This preserves normal invocation behavior for object payloads while avoiding crashes for empty, null, or primitive bodies.
Problem statement
callFunctionis exposed through bothGETandPOSTroutes. In normalGETrequests, or in requests where Express does not parse a body,req.bodycan beundefined.The previous implementation effectively relied on:
That throws
TypeError: Cannot convert undefined or null to objectwhenreq.bodyis missing, so the route fails before the function invocation is sent to the worker.Related issue
undefined,null, object, and primitive request bodiesType of change
How to test
cd faas && npm test.Fix: callFunction Request Body Handlingsuite passes.Checklist
Release notes
Fixed
callFunctionso requests without a parsed body no longer crash the FaaS route.