Skip to content

fix: replace fs.unlink with fs.rm for directory deletion in deleteFolder#138

Open
Karthikashanmugam05 wants to merge 5 commits intometacall:masterfrom
Karthikashanmugam05:fix-delete-folder-fs-rm
Open

fix: replace fs.unlink with fs.rm for directory deletion in deleteFolder#138
Karthikashanmugam05 wants to merge 5 commits intometacall:masterfrom
Karthikashanmugam05:fix-delete-folder-fs-rm

Conversation

@Karthikashanmugam05
Copy link
Copy Markdown

@Karthikashanmugam05 Karthikashanmugam05 commented Mar 26, 2026

Summary

Replaced fs.unlink with fs.rm for directory deletion in packageUpload to properly remove folders recursively. Cleaned up duplicate code and improved error handling.

Related issue

Fixes #N/A (no specific issue linked)

Type of change

  • Bug fix

How to test

Steps to reproduce or verify the change locally:

  1. Checkout the branch fix-delete-folder-fs-rm
  2. Run npm ci
  3. Run npm test and verify that folder deletion works correctly and tests pass

Checklist

  • I have read the contributing guidelines
  • I added tests that prove my fix is effective
  • I updated documentation if necessary

Notes for reviewers

Updated folder deletion logic to use fs.rm with recursive and force options, ensuring directories are removed safely.

Release notes

Fixed folder deletion bug in packageUpload.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant