fix: replace fs.unlink with fs.rm for directory deletion in deleteFolder#138
Open
Karthikashanmugam05 wants to merge 5 commits intometacall:masterfrom
Open
fix: replace fs.unlink with fs.rm for directory deletion in deleteFolder#138Karthikashanmugam05 wants to merge 5 commits intometacall:masterfrom
Karthikashanmugam05 wants to merge 5 commits intometacall:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaced fs.unlink with fs.rm for directory deletion in packageUpload to properly remove folders recursively. Cleaned up duplicate code and improved error handling.
Related issue
Fixes #N/A (no specific issue linked)
Type of change
How to test
Steps to reproduce or verify the change locally:
fix-delete-folder-fs-rmnpm cinpm testand verify that folder deletion works correctly and tests passChecklist
Notes for reviewers
Updated folder deletion logic to use fs.rm with recursive and force options, ensuring directories are removed safely.
Release notes
Fixed folder deletion bug in packageUpload.