fix(ci): switch healthcheck to wget and update Node.js to v20#126
Open
codxbrexx wants to merge 1 commit intometacall:masterfrom
Open
fix(ci): switch healthcheck to wget and update Node.js to v20#126codxbrexx wants to merge 1 commit intometacall:masterfrom
codxbrexx wants to merge 1 commit intometacall:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the silent failure of the FaaS test container readiness check and bumps the CI environment to use the current Active LTS version of Node.js.
healthcheckcommand fromcurltowget.curlis not installed in thefaasproduction runtime image, causing the healthcheck to constantly fail withsh: curl: not found. Added aservice_healthycondition so tests wait for the server.20instead of18(which reached End-of-Life in April 2025). This ensures tests run against a supported runtime.${FAAS_URL:-http://localhost:9000}.Related issue
sh: curl: not found).Type of change
How to test
fix/ci-healthchecksudo docker compose down --remove-orphans && sudo docker compose up --build --exit-code-from testwgetand the test container boots successfully instead of failing on theunhealthydependency.Checklist
Notes for reviewers
Node 18 is EOL and no longer receiving security updates, so upgrading the CI environment to Node 20 aligns with GitHub Actions' recommended runner environments and prevents deprecation warnings.
Release notes
Fixed Docker Compose test container healthcheck and updated CI environment to Node.js v20.