Skip to content

Fix for skirting being incorrectly frustum culled in VR #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kenamis wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix for skirting being incorrectly frustum culled in VR #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b7eac1c
Update QuadtreeRenderer.cs
kenamis Nov 27, 2025
31943d8
Update QuadtreeRenderer.cs
kenamis Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions com.meta.utilities.environment/Runtime/Scripts/Water/QuadtreeRenderer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,19 +132,19 @@ public void BeginContextRendering(List<Camera> cameras, MaterialPropertyBlock pr
// If a skirting range is required
if (m_skirtingSize > m_size)
{
using (ListPool<Matrix4x4>.Get(out var skirtingMatrices))
{
var offsetMatrix = Matrix4x4.Translate(m_currentGridCenter);
skirtingMatrices.Add(offsetMatrix * Matrix4x4.LookAt(Vector3.zero, new Vector3(0f, 0f, 1f), Vector3.up));
skirtingMatrices.Add(offsetMatrix * Matrix4x4.LookAt(Vector3.zero, new Vector3(1f, 0f, 0f), Vector3.up));
skirtingMatrices.Add(offsetMatrix * Matrix4x4.LookAt(Vector3.zero, new Vector3(0f, 0f, -1f), Vector3.up));
skirtingMatrices.Add(offsetMatrix * Matrix4x4.LookAt(Vector3.zero, new Vector3(-1f, 0f, 0f), Vector3.up));
foreach (var matrix in skirtingMatrices)
{
// These are drawn with DrawMesh so that they can cull individually and be depth sorted correctly
Graphics.DrawMesh(m_skirtingMesh, matrix, Material, gameObject.layer, camera, 0, propertyBlock, ShadowCastingMode.Off, false, null, LightProbeUsage.Off);
}
}
var rp = new RenderParams(Material);
rp.camera = camera;
rp.matProps = propertyBlock;
rp.shadowCastingMode = ShadowCastingMode.Off;
rp.layer = gameObject.layer;
rp.receiveShadows = false;
rp.lightProbeUsage = LightProbeUsage.Off;

//Updated Graphics.DrawMesh to newer Graphics.RenderMesh. Graphics.DrawMesh is obsolete per the Unity documentation
Graphics.RenderMesh(rp, m_skirtingMesh, 0, Matrix4x4.TRS(m_currentGridCenter, Quaternion.Euler(0f, 0f, 0f), Vector3.one));
Graphics.RenderMesh(rp, m_skirtingMesh, 0, Matrix4x4.TRS(m_currentGridCenter, Quaternion.Euler(0f, 90f, 0f), Vector3.one));
Graphics.RenderMesh(rp, m_skirtingMesh, 0, Matrix4x4.TRS(m_currentGridCenter, Quaternion.Euler(0f, 180f, 0f), Vector3.one));
Graphics.RenderMesh(rp, m_skirtingMesh, 0, Matrix4x4.TRS(m_currentGridCenter, Quaternion.Euler(0f, 270f, 0f), Vector3.one));
}
}
}
Expand Down