Skip to content

Basic Sandboxed Coder#297

Merged
allenwang28 merged 11 commits intometa-pytorch:mainfrom
allenwang28:coder
Oct 6, 2025
Merged

Basic Sandboxed Coder#297
allenwang28 merged 11 commits intometa-pytorch:mainfrom
allenwang28:coder

Conversation

@allenwang28
Copy link
Copy Markdown
Contributor

@allenwang28 allenwang28 commented Oct 2, 2025

follow up for #188

Enroot install instructions are here. Commands:

# Debian-based distributions
arch=$(dpkg --print-architecture)
curl -fSsL -O https://github.com/NVIDIA/enroot/releases/download/v4.0.0/enroot-hardened_4.0.0-1_${arch}.deb
curl -fSsL -O https://github.com/NVIDIA/enroot/releases/download/v4.0.0/enroot-hardened+caps_4.0.0-1_${arch}.deb # optional
sudo apt install -y ./*.deb

# RHEL-based distributions
arch=$(uname -m)
sudo dnf install -y epel-release # required on some distributions
sudo dnf install -y https://github.com/NVIDIA/enroot/releases/download/v4.0.0/enroot-hardened-4.0.0-1.el8.${arch}.rpm
sudo dnf install -y https://github.com/NVIDIA/enroot/releases/download/v4.0.0/enroot-hardened+caps-4.0.0-1.el8.${arch}.rpm # optional

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 2, 2025
Comment thread apps/vllm/main.py Outdated
Comment thread src/forge/actors/coder.py
Comment thread apps/vllm/main.py Outdated
Comment thread apps/vllm/main.py Outdated
@allenwang28
Copy link
Copy Markdown
Contributor Author

Quick updates:

Copy link
Copy Markdown
Contributor

@Jack-Khuu Jack-Khuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legit

Non-code ask:

  • Install instructions (README or just put in the PR description, until it's ready for the core install file)

@allenwang28
Copy link
Copy Markdown
Contributor Author

Install instructions (README or just put in the PR description, until it's ready for the core install file)

good call, added to the PR description

Comment thread src/forge/actors/coder.py Outdated
Comment thread src/forge/actors/coder.py Outdated
Comment thread src/forge/actors/coder.py Outdated
Comment thread src/forge/actors/coder.py Outdated
Comment thread tests/integration_tests/test_coder.py Outdated
Comment thread src/forge/actors/coder.py Outdated

async def stop_proc_mesh(self, proc_mesh: ProcMesh):
"""Stops a proc mesh."""
if proc_mesh not in self._proc_host_map:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this in here?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for some reason a bunch of unit tests were failing due to wrong cleanup. Not sure why I saw this in this PR specifically, but we should have this line anyways. If we want to be really clean I can add this in a separate PR

Comment thread src/forge/actors/coder.py
Comment thread src/forge/actors/coder.py Outdated
Comment thread src/forge/actors/coder.py Outdated
Copy link
Copy Markdown
Member

@joecummings joecummings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple nits, but looks good!

Comment thread src/forge/actors/coder.py Outdated
Comment thread src/forge/actors/coder.py Outdated
@allenwang28 allenwang28 merged commit 7b44035 into meta-pytorch:main Oct 6, 2025
8 checks passed
photomz pushed a commit to photomz/forge that referenced this pull request Oct 25, 2025
* hello coder

* docstrings

* undo vllm example

* add coder test

* double stop doesn't work

* address comments

* reset -> recreate

* remove line

* final cleanups
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants